Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version #430

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version #430

merged 5 commits into from
Aug 8, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Aug 7, 2024 •
edited
Loading

Contributes to rapidsai/build-planning#58.

scikit-build-core==0.10.0 was released today (https://github.com/scikit-build/scikit-build-core/releases/tag/v0.10.0), and wheel-building configurations across RAPIDS are incompatible with it.

This proposes upgrading to that version and fixing configuration here in a way that:

  • is compatible with that new scikit-build-core version
  • takes advantage of the forward-compatibility mechanism (minimum-version) that scikit-build-core provides, to reduce the risk of needing to do this again in the future

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 7, 2024
@jameslamb jameslamb changed the base branch from branch-24.10 to branch-24.08 August 7, 2024 02:19
@jameslamb jameslamb mentioned this pull request Aug 7, 2024
Closed
@jameslamb jameslamb changed the base branch from branch-24.08 to branch-24.10 August 7, 2024 14:18
@jameslamb
Copy link
Member Author

The devcontainers build should be fixed once rapidsai/devcontainers#377 is merged. Otherwise, this is ready for review.

@jameslamb jameslamb changed the title WIP: Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version Aug 7, 2024
@jameslamb jameslamb marked this pull request as ready for review August 7, 2024 15:43
@jameslamb jameslamb requested a review from a team as a code owner August 7, 2024 15:43
@jameslamb jameslamb requested a review from msarahan August 7, 2024 15:43
@jakirkham
Copy link
Member

Restarting failed CI jobs now that devcontainers have been updated

@jakirkham
Copy link
Member

Also noticed we are missing devcontainers here. Raised issue: rapidsai/ucxx#262

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 317c56c into rapidsai:branch-24.10 Aug 8, 2024
58 checks passed
@jakirkham
Copy link
Member

Thanks James! 🙏

@jameslamb jameslamb deleted the scikit-build-core-version branch August 8, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @jakirkham