-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use SKBUILD_BUILD_VERBOSE instead of SKBUILD_CMAKE_VERBOSE #377
Conversation
Looks like the CI failures here are the same ones already seen with |
I just restarted CI, now that there's a v0.10.1 of
I'm going to move this back to draft, let's not merge it yet. If those builds end up succeeding without any changes to any RAPIDS libraries, then that means we could target this at Will check back in the morning. |
/merge |
/merge |
Proposes switching from
SKBUILD_CMAKE_VERBOSE
toSKBUILD_BUILD_VERBOSE
in wheel-building scripts inrapids-build-utils
.Setting
SKBUILD_CMAKE_VERBOSE
in the environment causes an unavoidable build-time exception when usingscikit-build-core>=0.10.0
and settingminimum-version = "0.10.0"
inscikit-build-core
.(build link)
See https://scikit-build-core.readthedocs.io/en/latest/configuration.html#verbosity
Notes for Reviewers
For more context, see the conversation on that PR and rapidsai/build-planning#58.