Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dlopen: now trying "libcufile.so.1", "libcufile.so.0", "libcufile.so" #141

Merged
merged 2 commits into from
Oct 28, 2022
Merged

dlopen: now trying "libcufile.so.1", "libcufile.so.0", "libcufile.so" #141

merged 2 commits into from
Oct 28, 2022

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Oct 27, 2022

Fixes #140

@madsbk madsbk added bug Something isn't working non-breaking Introduces a non-breaking change c++ Affects the C++ API of KvikIO labels Oct 27, 2022
@madsbk madsbk marked this pull request as ready for review October 27, 2022 10:59
@madsbk
Copy link
Member Author

madsbk commented Oct 27, 2022

@quasiben can you test if this works for you?

@quasiben
Copy link
Member

Thanks @madsbk . This is working for me

@madsbk
Copy link
Member Author

madsbk commented Oct 28, 2022

thanks @quasiben

@madsbk madsbk closed this Oct 28, 2022
@madsbk madsbk reopened this Oct 28, 2022
@madsbk
Copy link
Member Author

madsbk commented Oct 28, 2022 •
edited
Loading

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b0c6ced into rapidsai:branch-22.12 Oct 28, 2022
@madsbk madsbk deleted the cufile_dlopen branch January 13, 2023 08:28
@jakirkham jakirkham mentioned this pull request Apr 26, 2023
Merged
rapids-bot bot pushed a commit to rapidsai/cucim that referenced this pull request Apr 27, 2023
@jakirkham
Only load versioned libcufile (#548)
8cbbe8f 
Fixes the `dlopen` logic around `libcufile` to load either the SOVERSION library or the fully versioned library. This includes logic to handle the missing SOVERSION library on older CUDA versions. Drops loading the stub library, which typically only shows up in development environments.

<hr>

Fixes #504

Borrows from PR ( rapidsai/cudf#13210 ) and PR ( rapidsai/kvikio#203 ). Also adapts this logic to cuCIM ( rapidsai/kvikio#141 )

Authors:
  - https://github.com/jakirkham
  - Gregory Lee (https://github.com/grlee77)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Gregory Lee (https://github.com/grlee77)
  - Gigon Bae (https://github.com/gigony)

URL: #548
vuule pushed a commit to vuule/kvikio that referenced this pull request Nov 8, 2023
@galipremsagar
Fix MultiIndex handling in read_parquet when engine='pyarrow' (r…
7feefc0 
…apidsai#141)

Fixes: rapidsai/cudf#14352

This PR switches the `engine='pyarrow'` call flow in `cudf.read_parquet` to `pd.read_parquet` because there is additional `MultiIndex` handling required which pyarrow will not perform and is being handled in pandas.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)

URL: rapidsai/cudf-private#141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasiben quasiben quasiben approved these changes

Assignees
No one assigned
Labels
bug Something isn't working c++ Affects the C++ API of KvikIO non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't find libcufile.so.1
2 participants
@madsbk @quasiben