Use canonicalized name for dlopen'd libraries (libcufile) #13210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's discussion going on here rapidsai/kvikio#203 about what the correct set of names is (some 11.5 deb packages don't ship the |
|
Right. After we settle on names for kvikio, let's copy that decision to this and other related PRs. |
|
Do we want to use KvikIO's |
libcudf can be built with cufile support but without kvikio support, so I don't think we can do this. |
wence-
reviewed
Apr 26, 2023
Co-authored-by: Lawrence Mitchell <[email protected]>
wence-
reviewed
Apr 26, 2023
bdice
approved these changes
Apr 26, 2023
divyegala
approved these changes
Apr 26, 2023
vuule
approved these changes
Apr 26, 2023
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cucim
that referenced
this pull request
Apr 27, 2023
Fixes the `dlopen` logic around `libcufile` to load either the SOVERSION library or the fully versioned library. This includes logic to handle the missing SOVERSION library on older CUDA versions. Drops loading the stub library, which typically only shows up in development environments. <hr> Fixes #504 Borrows from PR ( rapidsai/cudf#13210 ) and PR ( rapidsai/kvikio#203 ). Also adapts this logic to cuCIM ( rapidsai/kvikio#141 ) Authors: - https://github.com/jakirkham - Gregory Lee (https://github.com/grlee77) Approvers: - Bradley Dice (https://github.com/bdice) - Gregory Lee (https://github.com/grlee77) - Gigon Bae (https://github.com/gigony) URL: #548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #12708
Checklist