Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Treelite 2.2.1 #412

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jan 13, 2022

Required by rapidsai/cuml#4484. See the CI result in rapidsai/cuml#4484 which is testing cuML with Treelite 2.2.0.

EDIT. Using 2.2.1 patch release, to incorporate a hotfix (dmlc/treelite#340).

@hcho3 hcho3 requested a review from a team as a code owner January 13, 2022 20:32
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 13, 2022

Rerun tests

1 similar comment
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 13, 2022

Rerun tests

@hcho3 hcho3 changed the title Upgrade to Treelite 2.2.0 Upgrade to Treelite 2.2.1 Jan 15, 2022
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 15, 2022

rerun tests

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 15, 2022

Rerun tests

1 similar comment
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 15, 2022

Rerun tests

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 20, 2022

rerun tests

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 20, 2022

@ajschmidt8 Can you help with the failing meta-pkg-nightly?

@ajschmidt8
Copy link
Member

@ajschmidt8 Can you help with the failing meta-pkg-nightly?

Looking now

@ajschmidt8
Copy link
Member

@ajschmidt8 Can you help with the failing meta-pkg-nightly?

Looking now

Based on the stack trace that's in those logs, I've reached out to some people on the cugraph and ucx teams for some additional guidance here.

@ajschmidt8
Copy link
Member

@hcho3, there is a PR below to address this issue.

@ajschmidt8
Copy link
Member

rerun tests

3 similar comments
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 20, 2022

rerun tests

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 21, 2022

rerun tests

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 21, 2022

rerun tests

@ajschmidt8
Copy link
Member

The latest errors will be fixed once this PR is merged/deployed.

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 22, 2022

Rerun tests

1 similar comment
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 22, 2022

Rerun tests

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 24, 2022

Can we merge this? Thanks for fixing the CI.

@ajschmidt8 ajschmidt8 merged commit f58efe9 into rapidsai:branch-22.02 Jan 24, 2022
@hcho3 hcho3 deleted the upgrade_treelite branch January 24, 2022 18:57
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jan 25, 2022
The 2.2.0 version of Treelite incorporates the following major improvements:

* dmlc/treelite#314
* dmlc/treelite#322, dmlc/treelite#327
* dmlc/treelite#325
* dmlc/treelite#332
* dmlc/treelite#330
* dmlc/treelite#333
* dmlc/treelite#334
* dmlc/treelite#304
* dmlc/treelite#335

In particular, dmlc/treelite#332, dmlc/treelite#330, dmlc/treelite#333 are required for #4447.

Requires rapidsai/integration#412.

EDIT. Using 2.2.1 patch release, to incorporate a hotfix (dmlc/treelite#340).

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4484
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
The 2.2.0 version of Treelite incorporates the following major improvements:

* dmlc/treelite#314
* dmlc/treelite#322, dmlc/treelite#327
* dmlc/treelite#325
* dmlc/treelite#332
* dmlc/treelite#330
* dmlc/treelite#333
* dmlc/treelite#334
* dmlc/treelite#304
* dmlc/treelite#335

In particular, dmlc/treelite#332, dmlc/treelite#330, dmlc/treelite#333 are required for rapidsai#4447.

Requires rapidsai/integration#412.

EDIT. Using 2.2.1 patch release, to incorporate a hotfix (dmlc/treelite#340).

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants