Support cuML / scikit-learn RF classifiers in TreeExplainer #4447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
added
improvement
hcho3
changed the title
hcho3
changed the title
|
rerun tests |
hcho3
changed the title
ajschmidt8
reviewed
Jan 18, 2022
There was a problem hiding this comment.
Looks like this PR also includes changes from #4484. Is that intentional? If so, we'll need to wait for that to merge before this can merge.
|
@ajschmidt8 Yes, this is intentional, to show that the proposed changes in this PR are valid. We will need to wait until #4484 is merged. |
hcho3
force-pushed
the
classifier_support
branch
from
c1061ad to
0a4cc3e
Compare
|
Undoing accidentally pushed commits that should have been directed to #4473 |
|
rerun tests |
1 similar comment
|
rerun tests |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 25, 2022
The 2.2.0 version of Treelite incorporates the following major improvements: * dmlc/treelite#314 * dmlc/treelite#322, dmlc/treelite#327 * dmlc/treelite#325 * dmlc/treelite#332 * dmlc/treelite#330 * dmlc/treelite#333 * dmlc/treelite#334 * dmlc/treelite#304 * dmlc/treelite#335 In particular, dmlc/treelite#332, dmlc/treelite#330, dmlc/treelite#333 are required for #4447. Requires rapidsai/integration#412. EDIT. Using 2.2.1 patch release, to incorporate a hotfix (dmlc/treelite#340). Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Dante Gama Dessavre (https://github.com/dantegd) URL: #4484
|
@gpucibot merge |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #4447 +/- ##
===============================================
Coverage ? 85.68%
===============================================
Files ? 236
Lines ? 19334
Branches ? 0
===============================================
Hits ? 16567
Misses ? 2767
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@rapidsai/cuml-cmake-codeowners Can I get approval from one of you so that this can be merged? |
dantegd
approved these changes
Jan 26, 2022
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 28, 2022
Stacked on top of #4447. Do not merge until #4447 is merged first. ~If you'd like to review before #4447 is merged, look at the net diff at hcho3#2.~ - [x] Test XGBoost models with categorical splits - [x] Test LightGBM models with categorical splits Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #4473
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
The 2.2.0 version of Treelite incorporates the following major improvements: * dmlc/treelite#314 * dmlc/treelite#322, dmlc/treelite#327 * dmlc/treelite#325 * dmlc/treelite#332 * dmlc/treelite#330 * dmlc/treelite#333 * dmlc/treelite#334 * dmlc/treelite#304 * dmlc/treelite#335 In particular, dmlc/treelite#332, dmlc/treelite#330, dmlc/treelite#333 are required for rapidsai#4447. Requires rapidsai/integration#412. EDIT. Using 2.2.1 patch release, to incorporate a hotfix (dmlc/treelite#340). Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4484
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…#4447) Add support for: - [x] cuML RF classifiers - [x] scikit-learn RF regressors - [x] scikit-learn RF classifiers TODOs - [x] Add test cases - [x] De-duplicate path extraction logic Requires dmlc/treelite#330 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - William Hicks (https://github.com/wphicks) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4447
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Stacked on top of rapidsai#4447. Do not merge until rapidsai#4447 is merged first. ~If you'd like to review before rapidsai#4447 is merged, look at the net diff at hcho3#2.~ - [x] Test XGBoost models with categorical splits - [x] Test LightGBM models with categorical splits Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for:
TODOs
Requires dmlc/treelite#330