remove tools for working with S3-hosted docker images #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes removing the following scripts, which appear to be unused.
rapids-docker-multiarch-from-s3(GitHub search)rapids-download-docker-from-s3(GitHub search)rapids-upload-docker-from-s3(GitHub search)Found these while working through https://github.com/rapidsai/ops/issues/2982, looking for how
downloads.rapids.aiis used.Notes for Reviewers
These scripts were introduced in April 2023 (#51).
It seems then that the goal was to remove the need to use DockerHub for intermediate images used in producing the container images that RAPIDS projects run CI in:
Since then https://github.com/rapidsai/cibuildwheel-imgs, the only project these were intended to be used with (as far as I can tell) has been archived (rapidsai/ci-imgs#65).