Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge in cibuildwheels-imgs repository #65

Merged
merged 11 commits into from
Aug 28, 2023
Merged

Merge in cibuildwheels-imgs repository #65

merged 11 commits into from
Aug 28, 2023

Conversation

AyodeAwe
Copy link
Contributor

@AyodeAwe AyodeAwe commented Aug 23, 2023 •
edited
Loading

PR merges in the cibuildwheels-imgs repository into this one.

@AyodeAwe AyodeAwe force-pushed the merge-mforge branch 9 times, most recently from e15763d to f4c8cc2 Compare August 23, 2023 13:31
@AyodeAwe AyodeAwe force-pushed the merge-mforge branch 2 times, most recently from f60ccc2 to e8a1e8c Compare August 23, 2023 15:59
@AyodeAwe AyodeAwe marked this pull request as ready for review August 23, 2023 16:43
ajschmidt8
ajschmidt8 reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments.

I'd also like to request that we move the Dockerfiles to the top level instead of putting them in a dockerfiles folder.

They are the main resources in this repository, so it'll be most convenient if they're not buried in a folder.

.github/workflows/build-and-publish-images.yml Outdated Show resolved Hide resolved
.github/workflows/build-image.yml Outdated Show resolved Hide resolved
matrix.yaml Show resolved Hide resolved
ci/compute-matrix.jq Outdated Show resolved Hide resolved
ajschmidt8
ajschmidt8 reviewed Aug 25, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
latest.yaml Outdated Show resolved Hide resolved
ci/compute-matrix.jq Show resolved Hide resolved
ci/compute-matrix.jq Outdated Show resolved Hide resolved
ci/compute-matrix.jq Outdated Show resolved Hide resolved
ci/compute-latest-versions.sh Outdated Show resolved Hide resolved
matrix.yaml Outdated Show resolved Hide resolved
matrix.yaml Outdated Show resolved Hide resolved
matrix.yaml Outdated Show resolved Hide resolved
ajschmidt8
ajschmidt8 reviewed Aug 25, 2023
View reviewed changes
ci/compute-matrix.jq Outdated Show resolved Hide resolved
ci/compute-matrix.jq Show resolved Hide resolved
ajschmidt8
ajschmidt8 reviewed Aug 25, 2023
View reviewed changes
ci/create-multiarch-manifest.sh Outdated Show resolved Hide resolved
ci/compute-matrix.jq Outdated Show resolved Hide resolved
ajschmidt8
ajschmidt8 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the last set of changes.

once these are added, let's double-check the CI logs for correctness and then we can merge.

ci/compute-matrix.jq Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
matrix.yaml Show resolved Hide resolved
@ajschmidt8
Copy link
Member

pushed some whitespace-only changes. will merge pending CI completion

@ajschmidt8 ajschmidt8 merged commit 30a78f4 into rapidsai:main Aug 28, 2023
@ajschmidt8 ajschmidt8 mentioned this pull request Aug 28, 2023
Closed
@jameslamb jameslamb mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyodeAwe @ajschmidt8