Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUDA 12.5 to conda nightlys in the selector #522

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Add CUDA 12.5 to conda nightlys in the selector #522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b1a7c
Add CUDA 12.5 to conda nightlys
jarmak-nv Jul 17, 2024
d13a9b4
Revert to 12.2 if 12.5 is selected on click to stable
jarmak-nv Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion _includes/selector.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@

// all possible values
python_vers: ["3.9", "3.10", "3.11"],
cuda_vers: ["11.2", "11.8", "12.0", "12.2"],
cuda_vers: ["11.2", "11.8", "12.0", "12.2", "12.5"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cuda_vers: ["11.2", "11.8", "12.0", "12.2", "12.5"],
cuda_vers: ["11.4-11.8", "12.0-12.2", "12.0-12.5"],

Copy link
Contributor

@bdice bdice Jul 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but I don't think we need to have both 12.0-12.2 and 12.0-12.5. We should have only one CUDA 12 range.

Suggested change
cuda_vers: ["11.2", "11.8", "12.0", "12.2", "12.5"],
cuda_vers: ["11.4-11.8", "12.0-12.5"],

Copy link
Member

@jakirkham jakirkham Jul 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the only reason there are both now is one range is for nightlies and one is for stable (since the two are handled differently atm). If we did this after the release, we could just have one

pip_cuda_vers: ["11.2 - 11.8", "12"],
methods: ["Conda", "pip", "Docker"],
releases: ["Stable", "Nightly"],
Expand Down Expand Up @@ -675,6 +675,7 @@
var isDisabled = false;
if (this.active_additional_packages.includes("TensorFlow") && (cuda_version !== "12.0")) isDisabled = true;
if (this.active_method === "Docker" && cuda_version < "11.8") isDisabled = true;
if (this.active_release === "Stable" && cuda_version === "12.5") isDisabled = true;
return isDisabled;
},
disableUnsupportedPython(python_version) {
Expand Down Expand Up @@ -704,6 +705,9 @@
releaseClickHandler(e, release) {
if (this.isDisabled(e.target)) return;
this.active_release = release;
if ( this.active_release === "Stable" && this.active_cuda_ver === "12.5") {
this.active_cuda_ver = "12.2";
}
},
imgTypeClickHandler(e, type) {
if (this.isDisabled(e.target)) return;
Expand Down