-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CUDA 12.5 to conda nightlys in the selector #522
Conversation
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. We may be able to remove CUDA 11.2 from the selector, so that we don’t list 5 versions. conda-forge has moved entirely to building with 11.8, and we no longer test 11.2 in our CI workflows.
With this info, I'm in favor of removing 11.2 here and potentially doing an RSN to drop support altogether. Also curious if there's a benefit to having 12.0 here. My preference is that the selector helps get people on our recommended versions, so |
I like that. I would envision this:
How would that sound? |
cc: @sisodia1701 @raydouglass @jameslamb @KyleFromNVIDIA if you have thoughts on the discussions above |
I love this idea! In situations like this PR where there's a new nightly-only version of CUDA we can have a temp 3rd button that says something like: "RAPIDS 12.5 Pre-Release". I think that's not right, but something to show that it's upcoming support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ben! 🙏
Thinking about the discussion above, what if we converted this to CUDA version ranges?
This might also address some of the confusion raised by others in the past about what CUDA versions we support. Not to mention whether a CUDA version can be found that works with RAPIDS and other 3rd party libraries (like PyTorch)
Showed a small sample of this below. Though there may be other adjustments needed if we pursue this approach
@@ -371,7 +371,7 @@ | |||
|
|||
// all possible values | |||
python_vers: ["3.9", "3.10", "3.11"], | |||
cuda_vers: ["11.2", "11.8", "12.0", "12.2"], | |||
cuda_vers: ["11.2", "11.8", "12.0", "12.2", "12.5"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuda_vers: ["11.2", "11.8", "12.0", "12.2", "12.5"], | |
cuda_vers: ["11.4-11.8", "12.0-12.2", "12.0-12.5"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea but I don't think we need to have both 12.0-12.2
and 12.0-12.5
. We should have only one CUDA 12 range.
cuda_vers: ["11.2", "11.8", "12.0", "12.2", "12.5"], | |
cuda_vers: ["11.4-11.8", "12.0-12.5"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the only reason there are both now is one range is for nightlies and one is for stable (since the two are handled differently atm). If we did this after the release, we could just have one
@jakirkham @jarmak-nv I propose to merge this as-is, and file a follow-up PR with the changes we are proposing for CUDA version ranges instead of individual minor versions. |
SGTM |
Thanks all! 🙏 |
Small PR that adds CUDA 12.5 to the conda nightlys.
When 24.08 releases a followup PR will be made that: