Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dask-cudf #350

Closed
wants to merge 1 commit into from
Closed

Add dask-cudf #350

wants to merge 1 commit into from

Conversation

quasiben
Copy link
Member

@quasiben quasiben commented Mar 21, 2023

PR adds dask-cudf to the API section of https://docs.rapids.ai/api . Follow up PR for rapidsai/cudf#12725 and rapidsai/cudf#12982

cc @wence-

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't merge this yet.

Although there is a corresponding PR to cudf here: rapidsai/cudf#12982, the docs that are generated by GitHub Actions are not actually used by the docs website quite yet.

So merging the cudf PR above does not imply that this PR can be merged and the dask-cudf docs will show up on the docs site.

The docs that are published on our website are generated by a Jenkins job and committed directly to this repository.

We will eventually remove the docs that are committed to this repository and configure our website build process to pull the doc HTML files from S3.

Until that work is done, we will need to add dask-cudf to our Jenkins-based doc build process before we can merge this PR.

@quasiben
Copy link
Member Author

@ajschmidt8 should we merge in rapidsai/cudf#12982 and then ping for a jenkins build ?

@ajschmidt8
Copy link
Member

@ajschmidt8 should we merge in rapidsai/cudf#12982 and then ping for a jenkins build ?

Yup. No harm in merging rapidsai/cudf#12982.

@ajschmidt8
Copy link
Member

Closing this PR for now.

See #360 for details.

@ajschmidt8 ajschmidt8 closed this Apr 14, 2023
@ajschmidt8 ajschmidt8 mentioned this pull request Apr 19, 2023
@ajschmidt8
Copy link
Member

superseded by: #365

ajschmidt8 added a commit that referenced this pull request Apr 19, 2023
Duplicate of #350 now that the force push is complete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants