Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton API and prose documentation for dask-cudf #12725

Merged
merged 11 commits into from
Mar 21, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Feb 7, 2023

Description

Start building out documentation for dask-cudf, so that we have something other than the "10 minutes to ..." notebook.

In particular, this provides API documentation, and cross-linking to related projects such as Dask-CUDA.

@wence- wence- added doc Documentation non-breaking Non-breaking change labels Feb 7, 2023
@wence- wence- requested a review from a team as a code owner February 7, 2023 18:19
@wence- wence- self-assigned this Feb 7, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 7, 2023
@wence-
Copy link
Contributor Author

wence- commented Feb 7, 2023

cc: @jacobtomlinson, @beckernick, @quasiben who may have comments on the scope/suggestions.

As ever, cross-linking with sphinx is painful, but I think I have it warning free for now.

Since most of the docstrings are inherited from dask.dataframe, which in turn pastes them in from pandas, some of the cross-linking takes us off-site. I don't know a good way to fix that really.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@aff1c9f). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head bb0e896 differs from pull request most recent head 844a4ee. Consider uploading reports for the commit 844a4ee to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04   #12725   +/-   ##
===============================================
  Coverage                ?   85.81%           
===============================================
  Files                   ?      158           
  Lines                   ?    25154           
  Branches                ?        0           
===============================================
  Hits                    ?    21587           
  Misses                  ?     3567           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines 79 to 80
dataframe is already a Dask one or not. If you have a Dask dataframe,
then :func:`dask_cudf.from_dask_dataframe` will convert for you; if
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also do ddf.to_backend("cudf") now that #12380 was merged :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wence- can you add in a bit about ddf.to_backend("cudf") then we'll merge in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, although the intersphinxing didn't work because dask/dask#10093

@@ -25,6 +25,7 @@ Top-level conversions

cudf.to_numeric
cudf.from_dlpack
cudf.from_pandas
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this has never been linked in the cuDF API docs!

Comment on lines 79 to 80
dataframe is already a Dask one or not. If you have a Dask dataframe,
then :func:`dask_cudf.from_dask_dataframe` will convert for you; if
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, although the intersphinxing didn't work because dask/dask#10093

@quasiben
Copy link
Member

/merge

@rjzamora
Copy link
Member

Thanks @wence- !

@rapids-bot rapids-bot bot merged commit dc585de into rapidsai:branch-23.04 Mar 21, 2023
@wence- wence- deleted the wence/feature/dask-cudf-docs branch March 21, 2023 09:56
rapids-bot bot pushed a commit that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants