Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve build issues / consistency with conda-forge packages #883

Merged
merged 6 commits into from
Mar 30, 2022
Merged

Resolve build issues / consistency with conda-forge packages #883

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f62c6c0
Bump pynvml minimum version
charlesbluca Mar 30, 2022
6103e26
Bump minimum python version
charlesbluca Mar 30, 2022
be00abf
Add click max version constraint
charlesbluca Mar 30, 2022
8477147
Add click max version constraint
charlesbluca Mar 30, 2022
c2cf3c0
Correct constaint in requirements file
charlesbluca Mar 30, 2022
552d1c6
Pin click to 8.0.4
charlesbluca Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conda/recipes/dask-cuda/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ requirements:
- pynvml>=11.0.0
- numpy>=1.16.0
- numba>=0.53.1
- click<8.1
- click==8.0.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed offline and decided to match what was done in PR ( rapidsai/integration#453 ). The distributed issue this stems from is a bit different than the one that black encountered, but this pinning should work just as well here


test:
imports:
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributed==2022.03.0
pynvml>=11.0.0
numpy>=1.16.0
numba>=0.53.1
click<8.1
click==8.0.4