Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve build issues / consistency with conda-forge packages #883

Merged
merged 6 commits into from
Mar 30, 2022

Conversation

charlesbluca
Copy link
Member

@charlesbluca charlesbluca commented Mar 30, 2022

This PR:

  • bumps dask-cuda's minimum python version to 3.8 to coincide with other RAPIDS projects
  • bumps the pynvml minimum version to 11.0.0 to match up with the conda-forge package
  • adds a max version constraint for click to resolve the build issues arising from click 8.1.0

@charlesbluca charlesbluca requested a review from a team as a code owner March 30, 2022 17:29
@github-actions github-actions bot added the conda conda issue label Mar 30, 2022
@charlesbluca charlesbluca added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change conda conda issue bug Something isn't working and removed conda conda issue labels Mar 30, 2022
@charlesbluca charlesbluca changed the title Bump pynvml minimum version in conda recipe Update pynvml / python minimum version constraints Mar 30, 2022
@charlesbluca charlesbluca changed the title Update pynvml / python minimum version constraints Resolve build issues / consistency with conda-forge packages Mar 30, 2022
@jakirkham jakirkham requested a review from pentschev March 30, 2022 17:53
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #883 (c2cf3c0) into branch-22.04 (6ca650c) will increase coverage by 24.50%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           branch-22.04     #883       +/-   ##
=================================================
+ Coverage         65.02%   89.53%   +24.50%     
=================================================
  Files                22       16        -6     
  Lines              3074     2093      -981     
=================================================
- Hits               1999     1874      -125     
+ Misses             1075      219      -856     
Impacted Files Coverage Δ
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/benchmarks/utils.py
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/_version.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca650c...c2cf3c0. Read the comment docs.

conda/recipes/dask-cuda/meta.yaml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
- click<8.1
- click==8.0.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed offline and decided to match what was done in PR ( rapidsai/integration#453 ). The distributed issue this stems from is a bit different than the one that black encountered, but this pinning should work just as well here

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @charlesbluca !

@pentschev
Copy link
Member

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working conda conda issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants