-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve build issues / consistency with conda-forge packages #883
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #883 +/- ##
=================================================
+ Coverage 65.02% 89.53% +24.50%
=================================================
Files 22 16 -6
Lines 3074 2093 -981
=================================================
- Hits 1999 1874 -125
+ Misses 1075 219 -856 Continue to review full report at Codecov.
|
- click<8.1 | ||
- click==8.0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed offline and decided to match what was done in PR ( rapidsai/integration#453 ). The distributed
issue this stems from is a bit different than the one that black
encountered, but this pinning should work just as well here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @charlesbluca !
@gpucibot merge |
This PR:
click
to resolve the build issues arising from click 8.1.0