Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Temporarily skipping some tests because of a bug in Dask (#753)" #754

Merged
merged 3 commits into from
Nov 8, 2021
Merged

Revert "Temporarily skipping some tests because of a bug in Dask (#753)" #754

merged 3 commits into from
Nov 8, 2021

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Oct 11, 2021

Revert #753 when #746 has been fixed.

@madsbk madsbk requested a review from a team as a code owner October 11, 2021 07:55
@github-actions github-actions bot added the python python code needed label Oct 11, 2021
@madsbk madsbk added 5 - Merge After Dependencies Depends on another PR: do not merge out of order improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed python python code needed labels Oct 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@be4ffcc). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d1275f5 differs from pull request most recent head 64fadbf. Consider uploading reports for the commit 64fadbf to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12     #754   +/-   ##
===============================================
  Coverage                ?   89.12%           
===============================================
  Files                   ?       15           
  Lines                   ?     1913           
  Branches                ?        0           
===============================================
  Hits                    ?     1705           
  Misses                  ?      208           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be4ffcc...64fadbf. Read the comment docs.

@madsbk madsbk mentioned this pull request Nov 8, 2021
Merged
@github-actions github-actions bot added the python python code needed label Nov 8, 2021
pentschev
pentschev approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the liberty to resolve the conflicts here. LGTM, we can merge it when tests pass, thanks @madsbk !

@pentschev
Copy link
Member

rerun tests

@madsbk
Copy link
Member Author

madsbk commented Nov 8, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b659475 into rapidsai:branch-21.12 Nov 8, 2021
@madsbk madsbk deleted the revert_753 branch November 12, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
5 - Merge After Dependencies Depends on another PR: do not merge out of order improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsbk @codecov-commenter @pentschev