Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily skipping some tests because of a bug in Dask #753

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Temporarily skipping some tests because of a bug in Dask #753

merged 3 commits into from
Oct 11, 2021

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Oct 11, 2021

See #746

Will submit a PR that revert this when #746 has been merged.

@madsbk madsbk requested a review from a team as a code owner October 11, 2021 06:44
@github-actions github-actions bot added the python python code needed label Oct 11, 2021
@madsbk madsbk added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed python python code needed improvement Improvement / enhancement to an existing function labels Oct 11, 2021
pentschev
pentschev requested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea, thanks @madsbk . I think we need to use pytest.mark.skipif, added the suggestions.

dask_cuda/tests/test_explicit_comms.py Outdated Show resolved Hide resolved
dask_cuda/tests/test_proxy.py Outdated Show resolved Hide resolved
@madsbk @pentschev
Use pytest.mark.skipif()
2133f10 
Co-authored-by: Peter Andreas Entschev <[email protected]>
@github-actions github-actions bot added the python python code needed label Oct 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@7a426e8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12     #753   +/-   ##
===============================================
  Coverage                ?   79.57%           
===============================================
  Files                   ?       15           
  Lines                   ?     1914           
  Branches                ?        0           
===============================================
  Hits                    ?     1523           
  Misses                  ?      391           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a426e8...119f931. Read the comment docs.

pentschev
pentschev approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madsbk !

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 18cad78 into rapidsai:branch-21.12 Oct 11, 2021
@madsbk madsbk deleted the temp_skip_test_see_issue_746 branch October 11, 2021 07:51
madsbk added a commit to madsbk/dask-cuda that referenced this pull request Oct 11, 2021
@madsbk
Revert "Temporarily skipping some tests because of a bug in Dask (rap…
d1275f5 
…idsai#753)"

This reverts commit 18cad78.
@madsbk madsbk mentioned this pull request Oct 11, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request Nov 8, 2021
@madsbk
Revert "Temporarily skipping some tests because of a bug in Dask (#753)…
b659475 
…" (#754)

Revert #753 when #746 has been fixed.

Authors:
  - Mads R. B. Kristensen (https://github.com/madsbk)
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsbk @codecov-commenter @pentschev