Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cuDF Frame instead of Table #748

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Oct 5, 2021

In v21.12, cuDF removed Table in favor of Frame as base class, which is now part of the office API.

We now import cudf.core.frame.Frame if cudf._lib.table.Table isn't available.
Also, this PR adds some # type: ignore to make mypy pass.

@madsbk madsbk added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 5, 2021
@github-actions github-actions bot added the python python code needed label Oct 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@78326ee). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12     #748   +/-   ##
===============================================
  Coverage                ?   89.12%           
===============================================
  Files                   ?       15           
  Lines                   ?     1913           
  Branches                ?        0           
===============================================
  Hits                    ?     1705           
  Misses                  ?      208           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78326ee...75a3310. Read the comment docs.

@madsbk madsbk marked this pull request as ready for review October 5, 2021 13:20
@madsbk madsbk requested a review from a team as a code owner October 5, 2021 13:20
@madsbk madsbk added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 5, 2021
@madsbk
Copy link
Member Author

madsbk commented Oct 5, 2021

Notice, the CI error is because of #746 and will be fixed when dask/distributed#5380 has been merged.

15:17:34 Traceback (most recent call last):
15:17:34   File "/opt/conda/envs/rapids/lib/python3.7/site-packages/distributed/utils.py", line 648, in log_errors
15:17:34     yield
15:17:34   File "/opt/conda/envs/rapids/lib/python3.7/site-packages/cudf/comm/serialize.py", line 22, in cuda_deserialize_cudf_object
15:17:34     return Serializable.device_deserialize(header, frames)
15:17:34   File "/opt/conda/envs/rapids/lib/python3.7/site-packages/cudf/core/abc.py", line 142, in device_deserialize
15:17:34     obj = typ.deserialize(header, frames)
15:17:34   File "/opt/conda/envs/rapids/lib/python3.7/site-packages/cudf/core/dataframe.py", line 546, in deserialize
15:17:34     header, frames[header["index_frame_count"] :]
15:17:34   File "/opt/conda/envs/rapids/lib/python3.7/site-packages/cudf/core/frame.py", line 128, in deserialize
15:17:34     cls_deserialize = pickle.loads(header["type-serialized"])
15:17:34 ValueError: unsupported pickle protocol: 5

Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. We'll merge when the Dask PR is merged in

@madsbk madsbk added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 5, 2021
@ajschmidt8 ajschmidt8 merged commit 7a426e8 into rapidsai:branch-21.12 Oct 6, 2021
@madsbk madsbk deleted the fix_cudf_frame_import branch November 1, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants