-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cuDF Frame instead of Table #748
Use cuDF Frame instead of Table #748
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #748 +/- ##
===============================================
Coverage ? 89.12%
===============================================
Files ? 15
Lines ? 1913
Branches ? 0
===============================================
Hits ? 1705
Misses ? 208
Partials ? 0 Continue to review full report at Codecov.
|
Notice, the CI error is because of #746 and will be fixed when dask/distributed#5380 has been merged.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating. We'll merge when the Dask PR is merged in
In v21.12, cuDF removed Table in favor of Frame as base class, which is now part of the office API.
We now import
cudf.core.frame.Frame
ifcudf._lib.table.Table
isn't available.Also, this PR adds some
# type: ignore
to makemypy
pass.