Remove Table class #9315
Merged
Remove Table class #9315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
vyasr
force-pushed
the
refactor/remove_table
branch
from
678a53e to
4989279
Compare
|
rerun tests |
1 similar comment
|
rerun tests |
isVoid
reviewed
Sep 30, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9315 +/- ##
================================================
- Coverage 10.79% 10.76% -0.03%
================================================
Files 116 116
Lines 18869 19419 +550
================================================
+ Hits 2036 2090 +54
- Misses 16833 17329 +496
Continue to review full report at Codecov.
|
brandon-b-miller
approved these changes
Oct 4, 2021
isVoid
approved these changes
Oct 4, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Oct 6, 2021
This PR updates cuspatial to match the changes in rapidsai/cudf#9315. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Paul Taylor (https://github.com/trxcllnt) URL: #455
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the remaining logic from the Table class into the Frame class and removes the Table class entirely. In the long term we should move away from passing Frame objects into Cython functions since we should instead be able to make do with an iterable of columns, but changing the calling convention for our Cython APIs is left for future PRs. Once this one is merged, we can modify individual Cython APIs without having to touch any of the others.