Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop test setting UCX global options via Dask config #738

Merged

Conversation

pentschev
Copy link
Member

Support for setting UCX global options was dropped in
dask/distributed#4850, as the conflict of Dask
configs and UCX configs can be dangerous since both used to live in the
same namespace. Setting global UCX options can still be done via
environment variables, such as UCX_*, and is the preferred method now.

Fixes #627

Support for setting UCX global options was dropped in
dask/distributed#4850, as the conflict of Dask
configs and UCX configs can be dangerous since both used to live in the
same namespace. Setting global UCX options can still be done via
environment variables, such as `UCX_*`, and is the preferred method now.
@pentschev pentschev added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Sep 24, 2021
@pentschev pentschev requested a review from a team as a code owner September 24, 2021 13:14
@github-actions github-actions bot added the python python code needed label Sep 24, 2021
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pentschev

@pentschev
Copy link
Member Author

Thanks for another fast review @madsbk !

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #738 (9411629) into branch-21.10 (8e6ab70) will increase coverage by 1.54%.
The diff coverage is 86.41%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10     #738      +/-   ##
================================================
+ Coverage         87.63%   89.18%   +1.54%     
================================================
  Files                15       15              
  Lines              1658     1904     +246     
================================================
+ Hits               1453     1698     +245     
- Misses              205      206       +1     
Impacted Files Coverage Δ
dask_cuda/cuda_worker.py 77.64% <ø> (ø)
dask_cuda/get_device_memory_objects.py 90.00% <0.00%> (+21.94%) ⬆️
dask_cuda/utils.py 81.49% <60.52%> (-5.78%) ⬇️
dask_cuda/proxify_device_objects.py 95.45% <80.00%> (+6.56%) ⬆️
dask_cuda/initialize.py 90.47% <84.00%> (+1.58%) ⬆️
dask_cuda/proxify_host_file.py 93.51% <90.66%> (-5.88%) ⬇️
dask_cuda/proxy_object.py 91.34% <94.44%> (+1.70%) ⬆️
dask_cuda/device_host_file.py 71.66% <100.00%> (+1.50%) ⬆️
dask_cuda/explicit_comms/dataframe/shuffle.py 98.69% <100.00%> (+0.65%) ⬆️
dask_cuda/is_device_object.py 92.59% <100.00%> (+29.62%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8355187...9411629. Read the comment docs.

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit bd00b47 into rapidsai:branch-21.10 Sep 24, 2021
@pentschev pentschev deleted the drop-ucx-global-options-test branch October 22, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_global_option fails
3 participants