Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Deprecation/Future warnings as errors #672

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Jul 13, 2021

This will allow us to know about and resolve Dask deprecation cycles more quickly.

Fixes #666

This will allow us to know about and resolve Dask deprecation cycles
more quickly.
@pentschev pentschev requested review from a team as code owners July 13, 2021 21:06
@github-actions github-actions bot added gpuCI gpuCI issue python python code needed labels Jul 13, 2021
@pentschev pentschev added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jul 13, 2021
@pentschev pentschev added the feature request New feature or request label Jul 13, 2021
Copy link
Contributor

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pentschev!

FWIW, to your point in #666 (comment), it should be possible to only raise on warnings which are coming from specific libraries (here's how we target specific librarires like numpy and pandas over in dask)

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #672 (e347b0f) into branch-21.08 (79bc44e) will increase coverage by 27.47%.
The diff coverage is 100.00%.

❗ Current head e347b0f differs from pull request most recent head 47bec38. Consider uploading reports for the commit 47bec38 to get more accurate results
Impacted file tree graph

@@                Coverage Diff                @@
##           branch-21.08     #672       +/-   ##
=================================================
+ Coverage         60.19%   87.66%   +27.47%     
=================================================
  Files                21       15        -6     
  Lines              2605     1646      -959     
=================================================
- Hits               1568     1443      -125     
+ Misses             1037      203      -834     
Impacted Files Coverage Δ
dask_cuda/cli/dask_cuda_worker.py 95.71% <100.00%> (+0.06%) ⬆️
dask_cuda/cuda_worker.py 78.31% <100.00%> (ø)
dask_cuda/utils.py 86.32% <100.00%> (-1.42%) ⬇️
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/_version.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/utils.py
dask_cuda/benchmarks/local_cudf_shuffle.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79bc44e...47bec38. Read the comment docs.

@pentschev
Copy link
Member Author

FWIW, to your point in #666 (comment), it should be possible to only raise on warnings which are coming from specific libraries (here's how we target specific librarires like numpy and pandas over in dask)

Aha! That's good to know, thanks @jrbourbeau . I'll try it as is for now to see how it behaves, but if that becomes too demanding I'll limit it to Dask/Distributed only.

@quasiben
Copy link
Member

Thanks @pentschev !

@quasiben
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 379f90e into rapidsai:branch-21.08 Jul 20, 2021
@pentschev pentschev deleted the werror-deprecation branch July 20, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request gpuCI gpuCI issue non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise errors in CI on dask / distributed deprecations
5 participants