-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat Deprecation/Future warnings as errors #672
Treat Deprecation/Future warnings as errors #672
Conversation
This will allow us to know about and resolve Dask deprecation cycles more quickly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pentschev!
FWIW, to your point in #666 (comment), it should be possible to only raise on warnings which are coming from specific libraries (here's how we target specific librarires like numpy
and pandas
over in dask
)
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #672 +/- ##
=================================================
+ Coverage 60.19% 87.66% +27.47%
=================================================
Files 21 15 -6
Lines 2605 1646 -959
=================================================
- Hits 1568 1443 -125
+ Misses 1037 203 -834
Continue to review full report at Codecov.
|
Aha! That's good to know, thanks @jrbourbeau . I'll try it as is for now to see how it behaves, but if that becomes too demanding I'll limit it to Dask/Distributed only. |
Thanks @pentschev ! |
@gpucibot merge |
This will allow us to know about and resolve Dask deprecation cycles more quickly.
Fixes #666