Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise errors in CI on dask / distributed deprecations #666

Closed
jrbourbeau opened this issue Jul 2, 2021 · 1 comment · Fixed by #672
Closed

Raise errors in CI on dask / distributed deprecations #666

jrbourbeau opened this issue Jul 2, 2021 · 1 comment · Fixed by #672

Comments

@jrbourbeau
Copy link
Contributor

There's been interest from some Dask maintainers and folks on the RAPIDS team in Dask being more explicit about its public API. As a result we've started deprecating some utilities in dask and distributed (xref dask/distributed#4966, dask/dask#7810) and will eventually start making some methods private by prepending a leading underscore (_) to their name. We're planning to do this transition smoothly by raising FutureWarnings / DeprecationWarnings ahead of time to inform Dask users of any upcoming changes.

In light of this, is there any interest for dask-cuda (or other RAPIDS projects which use Dask) to start raising errors in CI on FutureWarnings / DeprecationWarnings which are raised from dask or distributed? This will help give dask-cuda developers a heads up on upcoming changes.

cc @rjzamora
@pentschev pentschev mentioned this issue Jul 13, 2021
Merged
@pentschev
Copy link
Member

Sorry for the delay here @jrbourbeau . I think this is generally a good idea, although this may become a burden if some of the other dependencies decide to start emitting too many of those. I've opened #672 so we can experiment with that for a while.

@rapids-bot rapids-bot bot closed this as completed in #672 Jul 20, 2021
rapids-bot bot pushed a commit that referenced this issue Jul 20, 2021
@pentschev
Treat Deprecation/Future warnings as errors (#672)
379f90e 
This will allow us to know about and resolve Dask deprecation cycles more quickly.

Fixes #666

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Jordan Jacobelli (https://github.com/Ethyling)
  - Benjamin Zaitlen (https://github.com/quasiben)

URL: #672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat Deprecation/Future warnings as errors pentschev/dask-cuda
2 participants
@pentschev @jrbourbeau