Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail if scheduler starts with '-' in dask-cuda-worker #485

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Fail if scheduler starts with '-' in dask-cuda-worker #485

merged 2 commits into from
Jan 5, 2021

Conversation

pentschev
Copy link
Member

Fixes #472

@pentschev pentschev requested a review from a team as a code owner January 4, 2021 22:51
@pentschev pentschev added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Jan 4, 2021
madsbk
madsbk approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madsbk madsbk added 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team labels Jan 5, 2021
@codecov-io
Copy link

codecov-io commented Jan 5, 2021 •
edited
Loading

Codecov Report

Merging #485 (6e144ff) into branch-0.18 (b170b29) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18     #485      +/-   ##
===============================================
+ Coverage        90.40%   90.42%   +0.01%     
===============================================
  Files               15       15              
  Lines             1126     1128       +2     
===============================================
+ Hits              1018     1020       +2     
  Misses             108      108
Impacted Files Coverage Δ
dask_cuda/cli/dask_cuda_worker.py 96.92% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b170b29...6e144ff. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 32d9d33 into rapidsai:branch-0.18 Jan 5, 2021
@pentschev
Copy link
Member Author

Thanks @madsbk for reviewing!

@pentschev pentschev deleted the fix-unknown-cli-option branch June 29, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing --scheduler-file will not raise error on wrong arguments
3 participants
@pentschev @codecov-io @madsbk