Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing --scheduler-file will not raise error on wrong arguments #472

Closed
pentschev opened this issue Dec 7, 2020 · 1 comment · Fixed by #485
Closed

Passing --scheduler-file will not raise error on wrong arguments #472

pentschev opened this issue Dec 7, 2020 · 1 comment · Fixed by #485

Comments

@pentschev
Copy link
Member

I just found out that for some reason passing wrong argument names to dask-cuda-worker will not fail when used with --scheduler-file, the following will start:

$ dask-cuda-worker --enable-tcp-over-ucx --enable-nvlink --enable-infiniband --ucx-net-devices=auto --scheduler-file scheduler.json

However, if you pass in the scheduler address it will fail, as the correct argument name is --net-devices:

$ dask-cuda-worker ucx://${SCHEDULER_IP}:8786 --enable-tcp-over-ucx --enable-nvlink --enable-infiniband --ucx-net-devices=auto
Usage: dask-cuda-worker [OPTIONS] [SCHEDULER] [PRELOAD_ARGV]...

Error: no such option: --ucx-net-devices=auto
@pentschev
Copy link
Member Author

After a bit of debugging it seems that the first incorrect option will be understood as being the scheduler argument even if it begins with --, thus if there's only one option that's incorrect it won't fail. This seems to be an intended consequence of click as it aims to be robust to options formatting and not just those starting with --.

@rapids-bot rapids-bot bot closed this as completed in #485 Jan 5, 2021
rapids-bot bot pushed a commit that referenced this issue Jan 5, 2021
Fixes #472

Authors:
  - Peter Andreas Entschev <[email protected]>

Approvers:
  - Mads R. B. Kristensen

URL: #485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant