Fix for bytes/str discrepancy after PyNVML update #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
bug
|
Requires dask/distributed#7544 to be merged first. |
wence-
approved these changes
Feb 15, 2023
|
/merge |
wence-
added a commit
to wence-/dask-cuda
that referenced
this pull request
Feb 22, 2023
PyNVML 11.5 makes a API-breaking change to the return types of (at least) nvmlDeviceGetName (producing str rather than bytes). On the development branch this was fixed by rapidsai#1118. To fix in 23.02, instead pin to the previously working version, rather than backporting.
Merged
raydouglass
pushed a commit
that referenced
this pull request
Feb 22, 2023
PyNVML 11.5 makes a API-breaking change to the return types of (at least) nvmlDeviceGetName (producing str rather than bytes). On the development branch this was fixed by #1118. To fix in 23.02, instead pin to the previously working version, rather than backporting. Authors: - Lawrence Mitchell (https://github.com/wence-) Approvers: - Ray Douglass (https://github.com/raydouglass)
3 tasks
wence-
added a commit
to wence-/dask-cuda
that referenced
this pull request
Feb 24, 2023
Handling the str vs. bytes discrepancy should have been covered by the changes in rapidsai#1118.
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
Handling the str vs. bytes discrepancy should have been covered by the changes in #1118. Authors: - Lawrence Mitchell (https://github.com/wence-) - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - https://github.com/jakirkham URL: #1130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PyNVML update has changed how some objects were previously returned bytes but now return str, which is now handled appropriately with this change.