Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

str/bytes compatibility for PyNVML device name #7563

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

jrbourbeau
Copy link
Member

No description provided.

@jrbourbeau jrbourbeau changed the title Test gpuCI str/bytes compatibility for PyNVML device name Feb 20, 2023
@jrbourbeau
Copy link
Member Author

We've started seeing the following test failures in gpuCI (for example, see this build)

14:55:11 FAILED distributed/diagnostics/tests/test_nvml.py::test_gpu_metrics - AttributeError: 'str' object has no attribute 'decode'
14:55:11 FAILED distributed/diagnostics/tests/test_nvml.py::test_gpu_monitoring_recent - AttributeError: 'str' object has no attribute 'decode'

Related to #7544

cc @pentschev @jacobtomlinson @wence-

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       24 files  ±0         24 suites  ±0   10h 4m 27s ⏱️ - 2m 20s
  3 337 tests ±0    3 231 ✔️  - 3     103 💤 ±0  3 +3 
39 343 runs  ±0  37 477 ✔️  - 4  1 863 💤 +1  3 +3 

For more details on these failures, see this check.

Results for commit 9d0b2f7. ± Comparison against base commit 242079d.

@quasiben
Copy link
Member

The error might be due to a recent update in PyNVML. xref: rapidsai/dask-cuda#1118

@wence- @charlesbluca do you have opinions here ?

Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrbourbeau, and sorry for missing this. This looks right since it now just asks the nvml diagnostics module to decode the name (which handles the str/bytes distinction).

@jrbourbeau
Copy link
Member Author

No worries @wence-! Thanks for reviewing

@jrbourbeau jrbourbeau merged commit a83d872 into dask:main Feb 22, 2023
@jrbourbeau jrbourbeau deleted the test-gpuci branch February 22, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants