Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Pin dask and distributed for release #1046

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Nov 16, 2022

This PR pins dask and distributed to 2022.11.1 for 22.12 release.

xref: rapidsai/cudf#12165

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 16, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner November 16, 2022 14:43
@galipremsagar galipremsagar self-assigned this Nov 16, 2022
@github-actions github-actions bot added the gpuCI gpuCI issue label Nov 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@55375b8). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff               @@
##             branch-22.12   #1046   +/-   ##
==============================================
  Coverage                ?   0.00%           
==============================================
  Files                   ?      18           
  Lines                   ?    2259           
  Branches                ?       0           
==============================================
  Hits                    ?       0           
  Misses                  ?    2259           
  Partials                ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galipremsagar
Copy link
Contributor Author

cc: @pentschev for review

@pentschev
Copy link
Member

I think we should wait until codefreeze, burndown is starting only tomorrow. Any reasons why we should do it this early?

@galipremsagar
Copy link
Contributor Author

I think we should wait until codefreeze, burndown is starting only tomorrow. Any reasons why we should do it this early?

We can wait if you would want us to across all repos. cudf code-freeze begins tomorrow, hence opening the PRs for all repos.

@pentschev
Copy link
Member

I guess it makes sense to pin it down once we are somewhat confident this is the version we want. Since code freeze for "others" (including Dask) starts December 1st, I'm imagining there will be another Dask release until then. I have no strong objections on doing this immediately, but if we do this is effectively a code-freeze regarding Dask, which is what we wanted to avoid.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Momentarily blocking this to raise a discussion.

@pentschev pentschev added the 0 - Blocked Cannot progress due to external reasons label Nov 16, 2022
@pentschev
Copy link
Member

Per our discussion, we decided we should pin during the second code freeze, for the upcoming release that is December 1st. I added the "blocked" label for this PR, which we can on that date update and merge. Thanks so much @galipremsagar for your effort here, it's really appreciated! 😄

@galipremsagar galipremsagar added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 0 - Blocked Cannot progress due to external reasons labels Nov 16, 2022
@galipremsagar galipremsagar removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Dec 1, 2022
@galipremsagar
Copy link
Contributor Author

pinging @pentschev for review

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar !

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ee40483 into rapidsai:branch-22.12 Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants