-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Pin dask
and distributed
for release
#1046
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #1046 +/- ##
==============================================
Coverage ? 0.00%
==============================================
Files ? 18
Lines ? 2259
Branches ? 0
==============================================
Hits ? 0
Misses ? 2259
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cc: @pentschev for review |
I think we should wait until codefreeze, burndown is starting only tomorrow. Any reasons why we should do it this early? |
We can wait if you would want us to across all repos. cudf code-freeze begins tomorrow, hence opening the PRs for all repos. |
I guess it makes sense to pin it down once we are somewhat confident this is the version we want. Since code freeze for "others" (including Dask) starts December 1st, I'm imagining there will be another Dask release until then. I have no strong objections on doing this immediately, but if we do this is effectively a code-freeze regarding Dask, which is what we wanted to avoid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Momentarily blocking this to raise a discussion.
Per our discussion, we decided we should pin during the second code freeze, for the upcoming release that is December 1st. I added the "blocked" label for this PR, which we can on that date update and merge. Thanks so much @galipremsagar for your effort here, it's really appreciated! 😄 |
pinging @pentschev for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @galipremsagar !
@gpucibot merge |
This PR pins
dask
anddistributed
to2022.11.1
for22.12
release.xref: rapidsai/cudf#12165