Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Pin dask and distributed for release #12165

Merged
merged 6 commits into from
Dec 2, 2022
Merged

[REVIEW] Pin dask and distributed for release #12165

merged 6 commits into from
Dec 2, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Nov 16, 2022 •
edited
Loading

Description

This PR pins dask and distributed to 2022.11.1 for 22.12 release.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 16, 2022
@galipremsagar galipremsagar self-assigned this Nov 16, 2022
@galipremsagar galipremsagar requested review from a team as code owners November 16, 2022 14:37
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Nov 16, 2022
This was referenced Nov 16, 2022
Merged
Merged
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Nov 16, 2022
@galipremsagar
Pin dask and distributed for release (#1022)
464a11b 
This PR pins `dask` and `distributed` to `2022.11.0` for `22.12` release.
xref: rapidsai/cudf#12165

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1022
@pentschev
Copy link
Member

I'd prefer we hold on to merging this until we have a chance to discuss internally if this is the time we really want to pin. Effectively this means an immediate code freeze related to Dask.

@galipremsagar galipremsagar added 0 - Blocked Cannot progress due to external reasons 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 3 - Ready for Review Ready for review by team 0 - Blocked Cannot progress due to external reasons labels Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022 •
edited
Loading

Codecov Report

Base: 88.13% // Head: 88.22% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (f0ab6d5) compared to base (414140b).
Patch coverage: 89.81% of modified lines in pull request are covered.

❗ Current head f0ab6d5 differs from pull request most recent head cbdefb8. Consider uploading reports for the commit cbdefb8 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.12   #12165      +/-   ##
================================================
+ Coverage         88.13%   88.22%   +0.09%     
================================================
  Files               135      137       +2     
  Lines             22135    22571     +436     
================================================
+ Hits              19508    19914     +406     
- Misses             2627     2657      +30
Impacted Files Coverage Δ
python/cudf/cudf/core/df_protocol.py 88.17% <ø> (ø)
python/cudf/cudf/core/index.py 92.88% <ø> (ø)
python/cudf/cudf/core/series.py 95.71% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 80.18% <ø> (ø)
python/dask_cudf/dask_cudf/backends.py 85.17% <ø> (ø)
python/strings_udf/strings_udf/__init__.py 75.80% <36.36%> (-8.51%) ⬇️
python/cudf/cudf/core/buffer/spill_manager.py 80.00% <80.00%> (ø)
python/cudf/cudf/options.py 87.69% <88.46%> (+0.51%) ⬆️
python/strings_udf/strings_udf/lowering.py 86.38% <92.68%> (+1.41%) ⬆️
python/cudf/cudf/core/buffer/spillable_buffer.py 92.85% <92.85%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr vyasr mentioned this pull request Nov 22, 2022
Merged
3 tasks
@galipremsagar galipremsagar removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Dec 1, 2022
This was referenced Dec 1, 2022
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Dec 1, 2022
@galipremsagar
Pin dask and distributed for release (#1046)
ee40483 
This PR pins `dask` and `distributed` to `2022.11.1` for `22.12` release.

xref: rapidsai/cudf#12165

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #1046
pentschev
pentschev approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar !

rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Dec 1, 2022
@galipremsagar
Pin dask and distributed for release (#2940)
1cfbfd7 
This PR pins `dask` and `distributed` to `2022.11.1` for `22.12` release.
xref: rapidsai/cudf#12165

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Brad Rees (https://github.com/BradReesWork)

URL: #2940
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Dec 1, 2022
@galipremsagar
Pin dask and distributed for release (#4999)
44f6f69 
This PR pins `dask` and `distributed` to `2022.11.1` for `22.12` release.

xref: rapidsai/cudf#12165

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #4999
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Dec 2, 2022
@AyodeAwe AyodeAwe merged commit 9cd9841 into rapidsai:branch-22.12 Dec 2, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@galipremsagar
Pin dask and distributed for release (rapidsai#4999)
f05be2e 
This PR pins `dask` and `distributed` to `2022.11.1` for `22.12` release.

xref: rapidsai/cudf#12165

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#4999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@charlesbluca charlesbluca charlesbluca approved these changes

@pentschev pentschev pentschev approved these changes

@raydouglass raydouglass raydouglass approved these changes

@jakirkham jakirkham jakirkham approved these changes

@wence- wence- wence- approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@galipremsagar @pentschev @wence- @jakirkham @raydouglass @charlesbluca @AyodeAwe