Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Refactor Spatial Join APIs to header-only #565

Closed
5 tasks done
harrism opened this issue Jun 15, 2022 · 4 comments · Fixed by #861
Closed
5 tasks done

[FEA] Refactor Spatial Join APIs to header-only #565

harrism opened this issue Jun 15, 2022 · 4 comments · Fixed by #861
Assignees
Labels
feature request New feature or request libcuspatial Relates to the cuSpatial C++ library

Comments

@harrism
Copy link
Member

harrism commented Jun 15, 2022

Create header-only APIs for the following and refactor existing APIs / tests on top of the header-only API:

See https://github.com/rapidsai/cuspatial/blob/branch-22.08/cpp/include/cuspatial/spatial_join.hpp

cuspatial::join_quadtree_and_bounding_boxes() completed by #861

Tasks

  1. feature request libcuspatial
    harrism
  2. feature request libcuspatial
    harrism
  3. feature request libcuspatial tests
    harrism
  4. feature request libcuspatial tests
    harrism
@harrism harrism added feature request New feature or request Needs Triage Need team to review and classify c++ labels Jun 15, 2022
@harrism harrism added this to the header-only C++ API milestone Jun 15, 2022
@trxcllnt trxcllnt self-assigned this Jun 15, 2022
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@jarmak-nv jarmak-nv moved this to Todo in cuSpatial Aug 2, 2022
@harrism harrism removed the Needs Triage Need team to review and classify label Aug 24, 2022
@harrism harrism self-assigned this Oct 24, 2022
@harrism harrism added libcuspatial Relates to the cuSpatial C++ library and removed c++ labels Nov 16, 2022
@harrism harrism moved this from Todo to In Progress in cuSpatial Dec 12, 2022
@harrism harrism removed their assignment Dec 12, 2022
@harrism harrism moved this from In Progress to Review in cuSpatial Jan 23, 2023
@harrism harrism linked a pull request Jan 23, 2023 that will close this issue
@harrism harrism linked a pull request Jan 23, 2023 that will close this issue
rapids-bot bot pushed a commit that referenced this issue Feb 1, 2023
Contributes to #565. Add header-only `cuspatial::join_quadtree_and_bounding_boxes`.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Michael Wang (https://github.com/isVoid)
  - Mark Harris (https://github.com/harrism)

URL: #861
@rapids-bot rapids-bot bot closed this as completed in #861 Feb 1, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in cuSpatial Feb 1, 2023
@trxcllnt trxcllnt reopened this Feb 2, 2023
@jarmak-nv
Copy link
Contributor

Completed with #861

@trxcllnt
Copy link
Contributor

trxcllnt commented Feb 3, 2023

@jarmak-nv there's two more methods this issue describes, so we've been keeping it open until they're all done.

@trxcllnt trxcllnt reopened this Feb 3, 2023
@jarmak-nv
Copy link
Contributor

jarmak-nv commented Feb 3, 2023

Oh apologies! I just saw status done. I'll reach out to confirm in the future.

Edit: figured it out - there was a workflow turned on in the project that auto-sets the issue to 'Done' when a linked PR is merged. I've disabled that workflow so it shouldn't happen again, sorry!

Second edit: I also see in the timeline it's clear you self-reopened, when viewing from the project the timeline isn't available. I should make a feature req.

@jarmak-nv jarmak-nv moved this from Done to In Progress in cuSpatial Feb 3, 2023
@harrism harrism closed this as completed Apr 18, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuSpatial Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcuspatial Relates to the cuSpatial C++ library
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants