Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port point_quadtree tests to header-only API #1006

Closed
Tracked by #565
harrism opened this issue Mar 23, 2023 · 0 comments · Fixed by #1019
Closed
Tracked by #565

Port point_quadtree tests to header-only API #1006

harrism opened this issue Mar 23, 2023 · 0 comments · Fixed by #1019
Assignees
@harrism
Labels
feature request New feature or request libcuspatial Relates to the cuSpatial C++ library tests Relating to tests and test automation

Comments

@harrism
Copy link
Member

harrism commented Mar 23, 2023

No description provided.

@harrism harrism mentioned this issue Mar 23, 2023
Closed
@harrism harrism self-assigned this Mar 23, 2023
@harrism harrism added tests Relating to tests and test automation improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library feature request New feature or request and removed improvement Improvement / enhancement to an existing function labels Mar 23, 2023
@harrism harrism mentioned this issue Mar 29, 2023
Merged
3 tasks
@harrism harrism moved this from Todo to In Progress in cuSpatial Mar 29, 2023
@harrism harrism moved this from In Progress to Review in cuSpatial Apr 4, 2023
@rapids-bot rapids-bot bot closed this as completed in #1019 Apr 5, 2023
rapids-bot bot pushed a commit that referenced this issue Apr 5, 2023
@harrism
Refactor spatial join tests (#1019)
ccf526a 
Closes #1006
Closes #1007

I realized that the `join_quadtree_and_bounding_boxes()` tests are redundant to the `quadtree_point_in_polygon` tests and `quadtree_point_to_nearest_linestring` tests since the "small" test is duplicated in those. So I eliminated that test and added expectations for `join_quadtree_and_bounding_boxes` in those tests.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Paul Taylor (https://github.com/trxcllnt)

URL: #1019
@github-project-automation github-project-automation bot moved this from Review to Done in cuSpatial Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrism harrism

Labels
feature request New feature or request libcuspatial Relates to the cuSpatial C++ library tests Relating to tests and test automation
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor spatial join tests harrism/cuspatial
1 participant
@harrism