This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
[RELEASE] cusignal v22.04 #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[gpuCI] Forward-merge branch-22.02 to branch-22.04 [skip gpuci]
[gpuCI] Forward-merge branch-22.02 to branch-22.04 [skip gpuci]
This PR add parity with MATLAB chirp, specifically complex output. Adding the following parameter (`dtype=cp.float64`) Example input (`w = cusignal.chirp(t, cf-100, t[-1], cf+100, dtype=cp.complex128)`) Perf on original ```bash test/test_waveforms.py ........ [100%] -------------- benchmark 'Chirp': 8 tests -------------- Name (time in us) Mean -------------------------------------------------------- test_chirp_gpu[quad-10-1-6-16384] 61.1752 (1.0) test_chirp_gpu[lin-10-1-6-16384] 61.2585 (1.00) test_chirp_gpu[hyp-10-1-6-16384] 63.2589 (1.03) test_chirp_gpu[log-10-1-6-16384] 70.5225 (1.15) test_chirp_cpu[lin-10-1-6-16384] 179.8704 (2.94) test_chirp_cpu[hyp-10-1-6-16384] 234.5341 (3.83) test_chirp_cpu[log-10-1-6-16384] 394.2949 (6.45) test_chirp_cpu[quad-10-1-6-16384] 403.2681 (6.59) -------------------------------------------------------- ``` Perf on new **Notice:** - float64 is about 4x faster... There was a bug in test suite causing memory copy ```bash ----------------- benchmark 'Chirp': 16 tests ------------------ Name (time in us) Mean ---------------------------------------------------------------- test_chirp_gpu[lin-10-1-6-16384-real] 17.7974 (1.0) test_chirp_gpu[quad-10-1-6-16384-complex] 18.9554 (1.07) test_chirp_gpu[quad-10-1-6-16384-real] 19.1889 (1.08) test_chirp_gpu[hyp-10-1-6-16384-real] 19.7320 (1.11) test_chirp_gpu[hyp-10-1-6-16384-complex] 19.7500 (1.11) test_chirp_gpu[lin-10-1-6-16384-complex] 22.5316 (1.27) test_chirp_gpu[log-10-1-6-16384-complex] 26.4949 (1.49) test_chirp_gpu[log-10-1-6-16384-real] 28.1316 (1.58) test_chirp_cpu[lin-10-1-6-16384-real] 182.4054 (10.25) test_chirp_cpu[hyp-10-1-6-16384-complex] 232.2149 (13.05) test_chirp_cpu[hyp-10-1-6-16384-real] 237.3360 (13.34) test_chirp_cpu[lin-10-1-6-16384-complex] 371.0492 (20.85) test_chirp_cpu[log-10-1-6-16384-complex] 386.9165 (21.74) test_chirp_cpu[log-10-1-6-16384-real] 397.7282 (22.35) test_chirp_cpu[quad-10-1-6-16384-complex] 404.0797 (22.70) test_chirp_cpu[quad-10-1-6-16384-real] 406.1122 (22.82) ---------------------------------------------------------------- ``` Authors: - Matthew Nicely (https://github.com/mnicely) Approvers: - Adam Thompson (https://github.com/awthomp) URL: #450
fixes #457 Authors: - Esosa E (https://github.com/sosae0) Approvers: - Adam Thompson (https://github.com/awthomp) URL: #458
This PR fixes an issue with the doc builds. `get_html_theme_path()` was removed in the commit below. After some local testing, it seems that the lines in this PR can be removed without any issues. - pydata/pydata-sphinx-theme@579d7ce Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar)
I implemented a `cusignal.correlation_lags` which works as expected, with notable increase in speed as expected compared to the [Scipy function]( https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.correlation_lags.html). I am still working on the pytest and will update that in [`test_convolution.py`](https://github.com/rapidsai/cusignal/blob/branch-22.04/python/cusignal/test/test_convolution.py) once completed soon. Authors: - Esosa E (https://github.com/sosae0) Approvers: - Adam Thompson (https://github.com/awthomp) URL: #459
In the near future, the [rapidsai/ops-bot](https://github.com/rapidsai/ops-bot) GitHub application that we use for GitHub automation will be enabled on all repositories in the `rapidsai` GitHub organization. Since not all features of the application are applicable to all repositories, this PR adds a new file, `.github/ops-bot.yaml`, which can configure which features are enabled per repository. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #463
I recently committed a config file to be used by the [rapidsai/ops-bot](https://github.com/rapidsai/ops-bot/) and in hindsight, I should've had the new `external_contributors` functionality set to `false` until we're ready to roll it out everywhere. This PR fixes that. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❄️ Code freeze for
branch-22.04and v22.04 releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
branch-22.04until release (merging of this PR).What is the purpose of this PR?
branch-22.04intomainfor the release