This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 133
adding complex parameter to chirp and additional tests #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awthomp
reviewed
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments here:
- I'm going to change the API from
dtype
totype
. IMO,dtype
tends to define input rather than output
* Complex output is currently only valid for a linear chirp, so I'll deprecate added functionality on quadratic and logarithmic - Algorithm for determining imaginary component of complex linear chirp output is incorrect.
I'll modify this PR. The framework is super handy :).
EDIT: Complex output type is supported by all chirp methods.
Test/Implementation script:
Usage
For this PR, let's enable complex support for linear mode only. |
awthomp
suggested changes
Jan 22, 2022
Also, let's be sure to add
|
awthomp
approved these changes
Jan 24, 2022
@gpucibot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3 - Ready for Review
Ready for review by team
feature request
New feature or request
non-breaking
Non-breaking change
Python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add parity with MATLAB chirp, specifically complex output.
Adding the following parameter (
dtype=cp.float64
)Example input (
w = cusignal.chirp(t, cf-100, t[-1], cf+100, dtype=cp.complex128)
)Perf on original
Perf on new
Notice: