Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable hnswlib feature in RAFT; pin pytest #5733

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Disable hnswlib feature in RAFT; pin pytest #5733

merged 2 commits into from
Jan 29, 2024

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jan 29, 2024 •
edited
Loading

This resolves cmake failures such as the following:

CMake Error at /home/coder/cuml/cpp/build/release/_deps/raft-build/raft-targets.cmake:56 (set_target_properties):
      The link interface of target "raft::raft" contains:
        hnswlib::hnswlib

Also pin pytest to 7.x to avoid breaking changes from pytest 8. See rapidsai/cudf#14920

@hcho3 hcho3 requested a review from a team as a code owner January 29, 2024 18:47
@hcho3 hcho3 added non-breaking Non-breaking change Build or Dep Issues related to building the code or dependencies improvement Improvement / enhancement to an existing function labels Jan 29, 2024
@hcho3 hcho3 requested review from a team as code owners January 29, 2024 18:57
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Jan 29, 2024
vyasr
vyasr approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake approval

@hcho3 hcho3 closed this Jan 29, 2024
@hcho3 hcho3 reopened this Jan 29, 2024
@hcho3 hcho3 changed the title Disable hnswlib feature in RAFT Disable hnswlib feature in RAFT; pin pytest Jan 29, 2024
@dantegd
Copy link
Member

dantegd commented Jan 29, 2024

/merge

@rapids-bot rapids-bot bot merged commit dd50df5 into rapidsai:branch-24.02 Jan 29, 2024
95 of 105 checks passed
@hcho3 hcho3 deleted the fix_hnswlib branch January 29, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
Build or Dep Issues related to building the code or dependencies CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hcho3 @dantegd @vyasr @raydouglass @bdice