Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pytest<8 #14920

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Pin pytest<8 #14920

merged 1 commit into from
Jan 29, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

This PR pins pytest to <8 because a new 8.0 release broke multiple integrations with other pytest extensions.
pytest-dev/pytest-asyncio#763

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 29, 2024
@galipremsagar galipremsagar self-assigned this Jan 29, 2024
@galipremsagar galipremsagar requested review from a team as code owners January 29, 2024 17:10
@galipremsagar galipremsagar requested review from wence- and brandon-b-miller and removed request for a team January 29, 2024 17:10
@github-actions github-actions bot added Python Affects Python cuDF API. conda labels Jan 29, 2024
bdice
bdice approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time we unpin this, we should probably pin pytest>=8.0.0,<9.0.0a0. We have been broken like this by every major pytest release in recent history, if I recall correctly.

@AyodeAwe AyodeAwe merged commit fc2b977 into rapidsai:branch-24.02 Jan 29, 2024
67 of 68 checks passed
@hcho3 hcho3 mentioned this pull request Jan 29, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jan 29, 2024
@hcho3
Disable hnswlib feature in RAFT; pin pytest (#5733)
dd50df5 
This resolves cmake failures such as the following:
```
CMake Error at /home/coder/cuml/cpp/build/release/_deps/raft-build/raft-targets.cmake:56 (set_target_properties):
      The link interface of target "raft::raft" contains:
        hnswlib::hnswlib
```

Also pin pytest to 7.x to avoid breaking changes from pytest 8. See rapidsai/cudf#14920

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Bradley Dice (https://github.com/bdice)
  - Ray Douglass (https://github.com/raydouglass)

URL: #5733
@vyasr vyasr mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@bdice bdice bdice approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @bdice @AyodeAwe