Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new raft::compiled_static targets #5572

Closed

Conversation

divyegala
Copy link
Member

rapidsai/raft#1746 added static targets for RAFT that can be used directly now instead of building RAFT static explicitly

@divyegala divyegala added bug Something isn't working non-breaking Non-breaking change labels Sep 1, 2023
@divyegala divyegala changed the title Use new raft::raft_static and raft::compiled_static targets Use new raft::compiled_static targets Sep 2, 2023
@divyegala divyegala marked this pull request as ready for review September 2, 2023 00:55
@divyegala divyegala requested a review from a team as a code owner September 2, 2023 00:55
cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
rapids-bot bot pushed a commit that referenced this pull request Sep 13, 2023
Pin the container-image for the CI clang-tidy check to a previous version as the latest change to move `rapidsai/ci:latest` to CUDA 12 seemingly broke the test. See this [log](https://github.com/rapidsai/cuml/actions/runs/5955794611/job/16155266993#step:9:1) for an example.

Also includes:
- #5562 
- #5572
- #5575

Authors:
  - Simon Adorf (https://github.com/csadorf)
  - Divye Gala (https://github.com/divyegala)
  - Robert Maynard (https://github.com/robertmaynard)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Bradley Dice (https://github.com/bdice)

URL: #5561
@dantegd
Copy link
Member

dantegd commented Sep 13, 2023

Closing now that #5561 has been merged, feel free to reopen if we still need it

@dantegd dantegd closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake CUDA/C++ non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants