Unblock CI for branch-23.10 #5561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a description to this PR body? I've been flagged as a reviewer but have no idea why these changes need to be made. |
@ajschmidt8 Sorry about that. I've added a description. |
wphicks
approved these changes
Aug 25, 2023
bdice
reviewed
Aug 25, 2023
Co-authored-by: Bradley Dice <[email protected]>
|
/ok to test |
csadorf
changed the title
dantegd
approved these changes
Aug 28, 2023
ajschmidt8
reviewed
Sep 1, 2023
ajschmidt8
approved these changes
Sep 1, 2023
…_clang-tidy_check_container_to_cuda_11.8
bdice
reviewed
Sep 8, 2023
| @@ -1030,8 +1030,7 @@ def test_pairwise_distances(metric: str, matrix_size, is_col_major): | |||
| # Test the pairwise_distance helper function. | |||
| rng = np.random.RandomState(0) | |||
|
|
|||
| # For fp64, compare at 13 decimals, (2 places less than the ~15 max) | |||
| compare_precision = 6 | |||
| compare_precision = 2 if metric == "nan_euclidean" else 4 | |||
There was a problem hiding this comment.
Would a comment be helpful here to justify the different values?
bdice
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
CMake looks good to me. I briefly compared it to rapidsai/cugraph#3842 for reference.
…_clang-tidy_check_container_to_cuda_11.8
csadorf
changed the title
|
/ok to test |
|
/ok to test |
|
/merge |
This was referenced Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin the container-image for the CI clang-tidy check to a previous version as the latest change to move
rapidsai/ci:latestto CUDA 12 seemingly broke the test. See this log for an example.Also includes:
raft::compiled_statictargets #5572conda mambabuildnotmamba mambabuild#5575