Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support no regularization in MNMG LogisticRegression #5558

Merged
merged 7 commits into from
Sep 21, 2023
Merged

[FEA] Support no regularization in MNMG LogisticRegression #5558

merged 7 commits into from
Sep 21, 2023

Conversation

lijinf2
Copy link
Contributor

@lijinf2 lijinf2 commented Aug 22, 2023 •
edited
Loading

Also adopted the code structure of the SG class to prepare for future PRs.

This PR depends on and has included PR 5567

@github-actions github-actions bot added Cython / Python Cython or Python issue CUDA/C++ labels Aug 22, 2023
@lijinf2 lijinf2 marked this pull request as ready for review August 22, 2023 21:35
@lijinf2 lijinf2 requested review from a team as code owners August 22, 2023 21:35
@lijinf2 lijinf2 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 22, 2023
@lijinf2 lijinf2 marked this pull request as draft August 23, 2023 18:50
@lijinf2 lijinf2 marked this pull request as ready for review August 24, 2023 22:24
@lijinf2 lijinf2 mentioned this pull request Aug 29, 2023
Merged
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 19, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dantegd
Copy link
Member

dantegd commented Sep 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit f10a320 into rapidsai:branch-23.10 Sep 21, 2023
50 checks passed
@lijinf2 lijinf2 mentioned this pull request Sep 21, 2023
Closed
rapids-bot bot pushed a commit that referenced this pull request Sep 29, 2023
@lijinf2
[FEA] Support multiple classes in multi-node-multi-gpu logistic regre…
3c4ceb9 
…ssion, from C++, Cython, to Dask Python class (#5565)

Github issue: #5501

This PR depends on and has included [PR 5558](#5558).

Authors:
  - Jinfeng Li (https://github.com/lijinf2)

Approvers:
  - Simon Adorf (https://github.com/csadorf)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #5565
@lijinf2 lijinf2 mentioned this pull request Oct 3, 2023
Merged
@lijinf2 lijinf2 deleted the lrmg_noreg branch June 26, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lijinf2 @dantegd