Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numba>=0.57. #5429

Closed
wants to merge 2 commits into from
Closed

Use numba>=0.57. #5429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c608ac1
Use numba>=0.57.
bdice May 19, 2023
42cfd28
Merge branch 'branch-23.06' into numba-0.57
bdice May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ci/release/apply_wheel_modifications.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,4 @@ sed -i "s/rmm/rmm${CUDA_SUFFIX}/g" python/pyproject.toml
if [[ $CUDA_SUFFIX == "-cu12" ]]; then
sed -i "s/cuda-python[<=>\.,0-9]*/cuda-python>=12.0,<13.0/g" python/pyproject.toml
sed -i "s/cupy-cuda11x/cupy-cuda12x/g" python/pyproject.toml
sed -i "s/numba[<=>\.,0-9]*/numba>=0.57/g" python/pyproject.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why is this no longer needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! This was needed to fix CUDA 12 wheels. Previously, we needed numba 0.57 (from PyPI) to make CUDA 12 work. However, 0.57 wasn't available for conda until today. To align these, we are requiring 0.57 everywhere and no longer need this workaround.

fi
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ dependencies:
- nbsphinx
- ninja
- nltk
- numba>=0.56.4,<0.57
- numba>=0.57
- numpydoc
- pip
- pydata-sphinx-theme
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ dependencies:
- dask-cudf==23.6.*
- distributed==2023.3.2.1
- joblib>=0.11
- numba>=0.56.4,<0.57
- numba>=0.57
# TODO: Are seaborn and scipy really hard dependencies, or should
# we make them optional (i.e. an extra for pip
# installation/run_constrained for conda)?
Expand Down
2 changes: 1 addition & 1 deletion python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ dependencies = [
"dask==2023.3.2",
"distributed==2023.3.2.1",
"joblib>=0.11",
"numba>=0.56.4,<0.57",
"numba>=0.57",
"raft-dask==23.6.*",
"scipy",
"seaborn",
Expand Down