Use numba>=0.57. #5429
Closed
Use numba>=0.57. #5429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci
conda
wphicks
approved these changes
May 19, 2023
dantegd
approved these changes
May 19, 2023
| @@ -19,5 +19,4 @@ sed -i "s/rmm/rmm${CUDA_SUFFIX}/g" python/pyproject.toml | |||
| if [[ $CUDA_SUFFIX == "-cu12" ]]; then | |||
| sed -i "s/cuda-python[<=>\.,0-9]*/cuda-python>=12.0,<13.0/g" python/pyproject.toml | |||
| sed -i "s/cupy-cuda11x/cupy-cuda12x/g" python/pyproject.toml | |||
| sed -i "s/numba[<=>\.,0-9]*/numba>=0.57/g" python/pyproject.toml | |||
There was a problem hiding this comment.
Just curious why is this no longer needed?
There was a problem hiding this comment.
Good question! This was needed to fix CUDA 12 wheels. Previously, we needed numba 0.57 (from PyPI) to make CUDA 12 work. However, 0.57 wasn't available for conda until today. To align these, we are requiring 0.57 everywhere and no longer need this workaround.
raydouglass
approved these changes
May 19, 2023
bdice
added
improvement
|
@raydouglass @dantegd @wphicks This might need re-approved since I opened it from draft state. It's ready to merge now that new cudf nightly builds have been uploaded. Might depend on #5434 for a build fix, not sure. |
raydouglass
approved these changes
May 24, 2023
wphicks
approved these changes
May 24, 2023
rapids-bot bot
pushed a commit
that referenced
this pull request
May 26, 2023
…pdates (#5434) This PR: - Adds missing RAFT headers - Addresses a change in cuDF's `drop_duplicates` / `unique` that no longer sorts the output (returns unique values in the input order) - Updates to `numba>=0.57` (closes #5429) - Skips umap-learn tests on ARM (#5441) Authors: - Dante Gama Dessavre (https://github.com/dantegd) - Bradley Dice (https://github.com/bdice) Approvers: - Divye Gala (https://github.com/divyegala) - William Hicks (https://github.com/wphicks) - Bradley Dice (https://github.com/bdice) - AJ Schmidt (https://github.com/ajschmidt8) URL: #5434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to
numba>=0.57, which is needed to avoid dependency conflicts with rapidsai/cudf#13337.Please merge after rapidsai/cudf#13337.