Ensure pytest is run from relevant directories in GH Actions
#5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
added
improvement
|
We found issues with cudf where pytest-xdist and code coverage didn't play well unless we were in just the right directory. This comment is left over from that discovery: |
bdice
reviewed
Dec 21, 2022
sevagh
approved these changes
Dec 21, 2022
|
(The Jenkins failure is expected. I manually canceled the Jenkins job for this PR since we've officially disabled Jenkins for |
bdice
approved these changes
Dec 21, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #5101 +/- ##
===============================================
Coverage ? 69.30%
===============================================
Files ? 192
Lines ? 12369
Branches ? 0
===============================================
Hits ? 8572
Misses ? 3797
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@gpucibot merge |
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
…sai#5101) This PR undoes some erroneous changes I made in rapidsai#5075. According to @bdice, it's necessary to `cd` into the relevant directories when running `pytest` to avoid issues with `codecov`. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Sevag H (https://github.com/sevagh) - Bradley Dice (https://github.com/bdice) URL: rapidsai#5101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR undoes some erroneous changes I made in #5075.
According to @bdice, it's necessary to
cdinto the relevant directories when runningpytestto avoid issues withcodecov.