Skip to content

Commit

Permalink
Ensure pytest is run from relevant directories in GH Actions (#5101)
Browse files Browse the repository at this point in the history
This PR undoes some erroneous changes I made in #5075.

According to @bdice, it's necessary to `cd` into the relevant directories when running `pytest` to avoid issues with `codecov`.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Sevag H (https://github.com/sevagh)
  - Bradley Dice (https://github.com/bdice)

URL: #5101
  • Loading branch information
ajschmidt8 authored Dec 21, 2022
1 parent b67e912 commit 58edeb4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
5 changes: 3 additions & 2 deletions ci/test_python_dask.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@
source "$(dirname "$0")/test_python_common.sh"

rapids-logger "pytest cuml-dask"
cd python/cuml/tests/dask
pytest \
--cache-clear \
--junitxml="${RAPIDS_TESTS_DIR}/junit-cuml-dask.xml" \
--cov-config=python/.coveragerc \
--cov-config=../../../.coveragerc \
--cov=cuml_dask \
--cov-report=xml:"${RAPIDS_COVERAGE_DIR}/cuml-dask-coverage.xml" \
--cov-report=term \
python/cuml/tests/dask
.
7 changes: 4 additions & 3 deletions ci/test_python_singlegpu.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@
source "$(dirname "$0")/test_python_common.sh"

rapids-logger "pytest cuml single GPU"
cd python/cuml/tests
pytest \
--numprocesses=8 \
--ignore=python/cuml/tests/dask \
--ignore=dask \
--cache-clear \
--junitxml="${RAPIDS_TESTS_DIR}/junit-cuml.xml" \
--cov-config=python/.coveragerc \
--cov-config=../../.coveragerc \
--cov=cuml \
--cov-report=xml:"${RAPIDS_COVERAGE_DIR}/cuml-coverage.xml" \
--cov-report=term \
python/cuml/tests
.

0 comments on commit 58edeb4

Please sign in to comment.