Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing type for ridge and linear models #4996

Merged
merged 6 commits into from
Dec 20, 2022

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Nov 15, 2022

Fixes #4906

@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Nov 15, 2022
@lowener lowener added bug Something isn't working non-breaking Non-breaking change labels Nov 15, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added CMake conda conda issue gpuCI gpuCI issue labels Dec 12, 2022
@lowener lowener changed the base branch from branch-22.12 to branch-23.02 December 13, 2022 13:36
@lowener lowener marked this pull request as ready for review December 13, 2022 13:39
@lowener lowener requested review from a team as code owners December 13, 2022 13:39
@lowener lowener removed gpuCI gpuCI issue conda conda issue CMake labels Dec 13, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 79.10% // Head: 79.16% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (cf25f17) compared to base (28e9f30).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #4996      +/-   ##
================================================
+ Coverage         79.10%   79.16%   +0.06%     
================================================
  Files               192      192              
  Lines             12378    12378              
================================================
+ Hits               9791     9799       +8     
+ Misses             2587     2579       -8     
Flag Coverage Δ
dask 45.80% <ø> (ø)
non-dask 69.17% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/metrics/pairwise_kernels.py 79.83% <0.00%> (+0.80%) ⬆️
python/cuml/neighbors/kernel_density.py 80.26% <0.00%> (+4.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lowener lowener added the 3 - Ready for Review Ready for review by team label Dec 19, 2022
@dantegd
Copy link
Member

dantegd commented Dec 20, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ff4f3cf into rapidsai:branch-23.02 Dec 20, 2022
ajschmidt8 pushed a commit to csadorf/cuml that referenced this pull request Dec 20, 2022
@lowener lowener deleted the 22.12-indexing-glm branch December 21, 2022 00:38
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CUDA/C++ Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Integer overflow in Linear Models
3 participants