Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Integer overflow in Linear Models #4906

Closed
lowener opened this issue Sep 29, 2022 · 0 comments · Fixed by #4996
Closed

[BUG] Integer overflow in Linear Models #4906

lowener opened this issue Sep 29, 2022 · 0 comments · Fixed by #4996
Assignees
@lowener
Labels
bug Something isn't working CUDA / C++ CUDA issue Cython / Python Cython or Python issue

Comments

@lowener
Copy link
Contributor

lowener commented Sep 29, 2022 •
edited
Loading

Some linear models are using int for the number of rows and columns, this can lead to integer overflow for big matrices.
Here is an example on Ridge:

cuml/cpp/src/glm/ridge.cuh

Line 94 in d65121a

int V_len = n_cols * n_cols;

Linking the more general issue: #2459, #4105
@lowener lowener added bug Something isn't working ? - Needs Triage Need team to review and classify labels Sep 29, 2022
@lowener lowener added CUDA / C++ CUDA issue Cython / Python Cython or Python issue and removed ? - Needs Triage Need team to review and classify labels Sep 29, 2022
@lowener lowener self-assigned this Sep 29, 2022
@lowener lowener mentioned this issue Nov 15, 2022
Merged
@lowener lowener mentioned this issue Dec 1, 2022
Merged
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Dec 8, 2022
@lowener
Add support for 64bit svdeig (#1060)
de24a94 
`raft::linalg::eigDC` already supports 64bit.
This will be useful for rapidsai/cuml#4906

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1060
rapids-bot bot pushed a commit that referenced this issue Dec 20, 2022
@lowener
Fix indexing type for ridge and linear models (#4996)
ff4f3cf 
Fixes #4906

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4996
ajschmidt8 pushed a commit to csadorf/cuml that referenced this issue Dec 20, 2022
@lowener @ajschmidt8
Fix indexing type for ridge and linear models (rapidsai#4996)
1e45c55 
Fixes rapidsai#4906

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4996
jakirkham pushed a commit to jakirkham/cuml that referenced this issue Feb 27, 2023
@lowener
Fix indexing type for ridge and linear models (rapidsai#4996)
d39a83b 
Fixes rapidsai#4906

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowener lowener

Labels
bug Something isn't working CUDA / C++ CUDA issue Cython / Python Cython or Python issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix indexing type for ridge and linear models lowener/cuml
1 participant
@lowener