Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estimators adaptation toward CPU/GPU interoperability #4918

Merged
merged 68 commits into from
Dec 8, 2022
Merged

Estimators adaptation toward CPU/GPU interoperability #4918

merged 68 commits into from
Dec 8, 2022

Conversation

viclafargue
Copy link
Contributor

No description provided.

viclafargue and others added 30 commits August 18, 2022 11:24
@viclafargue
Add device and memory type settings
06df028
@viclafargue
Apply changes
ba70967
@viclafargue
Add pytests
d19a6ef
@viclafargue
CPU/GPU dispatch according to device_type
687bf73
@viclafargue
Testing different input types
f120ac5
@viclafargue
Add code doc
1556de8
@viclafargue
Remove None of acceptable values for device_type and memory_type
62f4ea7
@dantegd @divyegala
Update for thrust 1.17 and fixes to accommodate for cuDF Buffer refac…
85c06a7 
…tor (rapidsai#4871)

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)
  - Victor Lafargue (https://github.com/viclafargue)

URL: rapidsai#4871
@robertmaynard @divyegala
Use rapids-cmake 22.10 best practice for RAPIDS.cmake location (rapid…
ef55502 
…sai#4862)

Removes possibility of another projects RAPIDS.cmake being used, and removes need to always download a version.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4862
@beckernick @divyegala
Remove unused cuDF imports (rapidsai#4873)
ac68939 
For housekeeping, this PR removes unused cuDF imports across a variety of files.

It does not refactor any code that currently relies on cuDF.

Authors:
  - Nick Becker (https://github.com/beckernick)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4873
@canonizer @divyegala
Import treelite models into FIL in a different precision (rapidsai#4839)
dadedda 
Import treelite models into FIL in a different precision.

- e.g. load float64 treelite models as a float32 FIL model, or vice versa

Authors:
  - Andy Adinets (https://github.com/canonizer)
  - William Hicks (https://github.com/wphicks)

Approvers:
  - Philip Hyunsu Cho (https://github.com/hcho3)
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#4839
@tarang-jain @divyegala
All points membership vector for HDBSCAN (rapidsai#4800)
9afdff5 
- [x] All points distance membership vector
- [x] All points outlier membership vector
- [x] All points probability in some cluster
- [x] All points membership vector
- [x] Tests

Authors:
  - Tarang Jain (https://github.com/tarang-jain)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4800
@divyegala
merging
0cdafd5
@divyegala
merging and style fix
ff6d60a
@divyegala
base to experimental, attributes available on cuml model, is_cuda_ava…
8c64303 
…ilable
@divyegala
copyright check
68e816f
@divyegala
fixing failing tests and MRO for predict
ecd8a0a
@divyegala
fixing mirroring of input/output
279004b
@viclafargue
Requested changes
eb54d3f
@viclafargue
Merge branch 'branch-22.10' into cpu-gpu-interop
d6c2dde
@viclafargue
Requested changes 2
0f3922a
@viclafargue
Requested changes 3
c3dda60
@viclafargue
Fix import
bfe238f
@viclafargue
Fix tests
5c03489
@viclafargue
Using raft::KeyValuePair instead of cub::KeyValuePair
09db802
@cjnolet
Revert "Using raft::KeyValuePair instead of cub::KeyValuePair"
0dbe8a4 
This reverts commit 09db802.
@viclafargue
Fix _check_internal_model
495c676
@viclafargue
Generic testing
73bb16c
@viclafargue
Adding UMAP
a232ff6
@viclafargue
Adding LogisticRegression
edc4d84
@wphicks wphicks mentioned this pull request Dec 1, 2022
Open
@viclafargue
Copy link
Contributor Author

rerun tests

@wphicks
Copy link
Contributor

wphicks commented Dec 7, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented Dec 8, 2022

Same issue as other Prs, for some reason the Branch checker job is stuck in a couple of PRs, will work on solving that or admin merging later today

@dantegd
Copy link
Member

dantegd commented Dec 8, 2022

@viclafargue could you merge branch-23.02 into the PR to remove some file diffs that were not changed here?

@viclafargue viclafargue requested review from a team as code owners December 8, 2022 11:29
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@aba6889). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.02    #4918   +/-   ##
===============================================
  Coverage                ?   79.81%           
===============================================
  Files                   ?      184           
  Lines                   ?    11758           
  Branches                ?        0           
===============================================
  Hits                    ?     9385           
  Misses                  ?     2373           
  Partials                ?        0
Flag Coverage Δ
dask 46.05% <0.00%> (?)
non-dask 69.39% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cjnolet
cjnolet approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjnolet cjnolet removed the request for review from a team December 8, 2022 17:27
@csadorf csadorf added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Dec 8, 2022
@wphicks
Copy link
Contributor

wphicks commented Dec 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6953aa8 into rapidsai:branch-23.02 Dec 8, 2022
@beckernick beckernick mentioned this pull request Dec 13, 2022
Closed
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@viclafargue
Estimators adaptation toward CPU/GPU interoperability (rapidsai#4918)
199252a 
Authors:
  - Victor Lafargue (https://github.com/viclafargue)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Robert Maynard (https://github.com/robertmaynard)
  - Nick Becker (https://github.com/beckernick)
  - Andy Adinets (https://github.com/canonizer)
  - Tarang Jain (https://github.com/tarang-jain)
  - Divye Gala (https://github.com/divyegala)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Carl Simon Adorf (https://github.com/csadorf)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@csadorf csadorf csadorf approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@viclafargue viclafargue

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.