Import treelite models into FIL in a different precision #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
approved these changes
Jul 29, 2022
python/cuml/fil/fil.pyx
Outdated
| precision_dict = {'native': precision_t.PRECISION_NATIVE, | ||
| 'float32': precision_t.PRECISION_FLOAT32, | ||
| 'float64': precision_t.PRECISION_FLOAT64} | ||
| if precision not in precision_dict.keys(): |
There was a problem hiding this comment.
Suggested change
| if precision not in precision_dict.keys(): | |
| if precision not in precision_dict: |
to be more Pythonic
|
I've addressed the review comments. Could you take another look? |
|
Removing |
|
rerun tests |
wphicks
added
feature request
|
rerun tests |
1 similar comment
|
rerun tests |
|
rerun tests |
|
rerun tests |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #4839 +/- ##
================================================
+ Coverage 78.02% 78.04% +0.01%
================================================
Files 180 180
Lines 11385 11421 +36
================================================
+ Hits 8883 8913 +30
- Misses 2502 2508 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wphicks
approved these changes
Aug 26, 2022
|
@gpucibot merge |
divyegala
pushed a commit
to viclafargue/cuml
that referenced
this pull request
Sep 2, 2022
Import treelite models into FIL in a different precision. - e.g. load float64 treelite models as a float32 FIL model, or vice versa Authors: - Andy Adinets (https://github.com/canonizer) - William Hicks (https://github.com/wphicks) Approvers: - Philip Hyunsu Cho (https://github.com/hcho3) - William Hicks (https://github.com/wphicks) URL: rapidsai#4839
ajschmidt8
pushed a commit
that referenced
this pull request
Feb 13, 2023
Import treelite models into FIL in a different precision. - e.g. load float64 treelite models as a float32 FIL model, or vice versa Authors: - Andy Adinets (https://github.com/canonizer) - William Hicks (https://github.com/wphicks) Approvers: - Philip Hyunsu Cho (https://github.com/hcho3) - William Hicks (https://github.com/wphicks) URL: #4839
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
Import treelite models into FIL in a different precision. - e.g. load float64 treelite models as a float32 FIL model, or vice versa Authors: - Andy Adinets (https://github.com/canonizer) - William Hicks (https://github.com/wphicks) Approvers: - Philip Hyunsu Cho (https://github.com/hcho3) - William Hicks (https://github.com/wphicks) URL: rapidsai#4839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import treelite models into FIL in a different precision.