Rewrite CD solver using more BLAS #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achirkin
added
3 - Ready for Review
cjnolet
requested changes
Dec 13, 2021
|
rerun tests |
achirkin
added
2 - In Progress
achirkin
added
3 - Ready for Review
|
rerun tests |
dantegd
requested changes
Jan 24, 2022
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Feb 4, 2022
Add a few overloads for raft-CUBLAS `gemv`, `gemm`, `axpy` functions to support switching between host and device pointer mode. This allows passing some of the parameters (constants `alpha`, `beta`) as device pointers, which sometimes improves performance. By default, CUBLAS context is created in the host pointer mode. To keep this presumption, the device pointer mode is enabled only for the time of a particular CUBLAS call. This feature is required for rapidsai/cuml#4446. Authors: - Artem M. Chirkin (https://github.com/achirkin) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - Corey J. Nolet (https://github.com/cjnolet) URL: #453
|
rerun tests |
achirkin
commented
Feb 8, 2022
|
rerun tests |
dantegd
approved these changes
Feb 9, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #4446 +/- ##
===============================================
Coverage ? 85.73%
===============================================
Files ? 239
Lines ? 19585
Branches ? 0
===============================================
Hits ? 16792
Misses ? 2793
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Reduce the frequency of device-host data transfers and replace some operations with BLAS axpy/gemv routines. This brings approximately 1.2x-3x speedup against the previous version (more speedup for smaller problem sizes). Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - Dante Gama Dessavre (https://github.com/dantegd) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the frequency of device-host data transfers and replace some operations with BLAS axpy/gemv routines.
This brings approximately 1.2x-3x speedup against the previous version (more speedup for smaller problem sizes).