Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NVTX range helpers to raft #4445

Merged
merged 10 commits into from
Dec 17, 2021
Merged

Move NVTX range helpers to raft #4445

merged 10 commits into from
Dec 17, 2021

Conversation

achirkin
Copy link
Contributor

Move NVTX range helpers to raft and extend them a little bit.
Corresponding raft PR: rapidsai/raft#416 .

@achirkin achirkin requested review from a team as code owners December 13, 2021 12:28
@github-actions github-actions bot added CMake CUDA/C++ Cython / Python Cython or Python issue labels Dec 13, 2021
@achirkin achirkin added 2 - In Progress Currenty a work in progress breaking Breaking change feature request New feature or request and removed Cython / Python Cython or Python issue CMake CUDA/C++ labels Dec 13, 2021
@github-actions github-actions bot added CMake CUDA/C++ Cython / Python Cython or Python issue labels Dec 13, 2021
dantegd
dantegd previously requested changes Dec 13, 2021
View reviewed changes
python/cuml/common/cuda.pyx Outdated Show resolved Hide resolved
@achirkin achirkin requested a review from dantegd December 13, 2021 14:55
@achirkin

This comment has been minimized.

Sign in to view
@cjnolet
Copy link
Member

cjnolet commented Dec 13, 2021

rerun tests

@achirkin
Copy link
Contributor Author

rerun tests

@achirkin achirkin added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Dec 14, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@b9b97fc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4445   +/-   ##
===============================================
  Coverage                ?   78.65%           
===============================================
  Files                   ?      223           
  Lines                   ?    18537           
  Branches                ?        0           
===============================================
  Hits                    ?    14580           
  Misses                  ?     3957           
  Partials                ?        0
Flag Coverage Δ
non-dask 78.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b97fc...3c7e41e. Read the comment docs.

@cjnolet cjnolet dismissed dantegd’s stale review December 17, 2021 14:49

Dante is on vacation.

cjnolet
cjnolet approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Dec 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d630156 into rapidsai:branch-22.02 Dec 17, 2021
@wphicks wphicks mentioned this pull request Dec 18, 2021
Open
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@achirkin
Move NVTX range helpers to raft (rapidsai#4445)
0be4062 
Move NVTX range helpers to raft  and extend them a little bit.
Corresponding raft PR: rapidsai/raft#416 .

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@dantegd dantegd Awaiting requested review from dantegd

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team breaking Breaking change CMake CUDA/C++ Cython / Python Cython or Python issue feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achirkin @cjnolet @codecov-commenter @dantegd