Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Use official NVTX wrappers rather than those from RAFT #4458

Open
wphicks opened this issue Dec 18, 2021 · 4 comments
Open

[TASK] Use official NVTX wrappers rather than those from RAFT #4458

wphicks opened this issue Dec 18, 2021 · 4 comments
Labels
? - Needs Triage Need team to review and classify improvement Improvement / enhancement to an existing function inactive-30d inactive-90d Tech Debt Issues related to debt

Comments

@wphicks
Copy link
Contributor

wphicks commented Dec 18, 2021

In discussion on #4445, it was pointed out that NVTX itself provides the same functionality that we currently use from RAFT for scoped NVTX range objects. It would be useful to standardize on this upstream tool for NVTX range objects.

@wphicks wphicks added feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 18, 2021
@wphicks
Copy link
Contributor Author

wphicks commented Dec 18, 2021

@cjnolet @jrhemstad @achirkin Opened this issue to track offline discussion that was begun around NVTX ranges. Assuming we do go this route, we should probably open similar issues in any other RAPIDS libraries that make use of these NVTX wrappers (or other custom wrappers) and then remove the custom version from RAFT.

@wphicks wphicks added improvement Improvement / enhancement to an existing function Tech Debt Issues related to debt and removed feature request New feature or request labels Dec 18, 2021
@achirkin
Copy link
Contributor

Would be nice if we managed to merge upstream the extra features from our implementation: vararg-formatted messages and randomly assigned visually distinctive colors.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify improvement Improvement / enhancement to an existing function inactive-30d inactive-90d Tech Debt Issues related to debt
Projects
None yet
Development

No branches or pull requests

2 participants