Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FAISS with RMM #4297

Merged
merged 9 commits into from
Mar 8, 2022
Merged

Use FAISS with RMM #4297

merged 9 commits into from
Mar 8, 2022

Conversation

viclafargue
Copy link
Contributor

Answers #2821

@viclafargue viclafargue requested a review from a team as a code owner October 20, 2021 15:57
@viclafargue viclafargue added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 20, 2021
@viclafargue viclafargue requested a review from a team as a code owner October 20, 2021 17:08
@github-actions github-actions bot added the CMake label Oct 20, 2021
@viclafargue
Copy link
Contributor Author

rerun tests

@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@cjnolet
Copy link
Member

cjnolet commented Dec 4, 2021

rerun tests

@cjnolet cjnolet changed the base branch from branch-21.12 to branch-22.02 December 5, 2021 20:12
@cjnolet
Copy link
Member

cjnolet commented Dec 5, 2021

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Dec 6, 2021

rerun tests

1 similar comment
@cjnolet
Copy link
Member

cjnolet commented Dec 6, 2021

rerun tests

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@cjnolet
Copy link
Member

cjnolet commented Jan 18, 2022

@viclafargue, it looks like this PR isn't really required to merge rapidsai/raft#363 since it's just updating HDBSCAN to use the new FAISS allocator. Is that correct? If so, I'm thinking maybe we should merge the RAFT side into 22.02.

@viclafargue
Copy link
Contributor Author

@viclafargue, it looks like this PR isn't really required to merge rapidsai/raft#363 since it's just updating HDBSCAN to use the new FAISS allocator. Is that correct? If so, I'm thinking maybe we should merge the RAFT side into 22.02.

Sure, let's do that.

dantegd
dantegd requested changes Jan 24, 2022
View reviewed changes
cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the CMake label Jan 24, 2022
@dantegd dantegd changed the base branch from branch-22.02 to branch-22.04 February 3, 2022 16:48
@dantegd
Copy link
Member

dantegd commented Feb 11, 2022

rerun tests

1 similar comment
@cjnolet
Copy link
Member

cjnolet commented Feb 24, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented Mar 7, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@d2099b8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4297   +/-   ##
===============================================
  Coverage                ?   83.90%           
===============================================
  Files                   ?      250           
  Lines                   ?    20119           
  Branches                ?        0           
===============================================
  Hits                    ?    16880           
  Misses                  ?     3239           
  Partials                ?        0
Flag Coverage Δ
dask 45.08% <0.00%> (?)
non-dask 77.01% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2099b8...d360063. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Mar 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4c1d671 into rapidsai:branch-22.04 Mar 8, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
Use FAISS with RMM (rapidsai#4297)
0f24842 
Answers rapidsai#2821

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viclafargue @cjnolet @dantegd @codecov-commenter