-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Use RMM with FAISS GPUResources #2821
Comments
This is currently blocked by conda-forge/faiss-split-feedstock#17. We need to wait for the FAISS 1.6.4 conda package |
Just FYI, conda-forge/faiss-split-feedstock#17 has been merged 🙃 |
This change will also require the hardcoded |
Particularly important for approximate NN, in which FAISS owns a larger block of memory. Will also require updating indices back to 32-bit for newer FAISS rev. |
This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d. |
This issue has been labeled |
Answers rapidsai/cuml#2821 Authors: - Victor Lafargue (https://github.com/viclafargue) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #363
Answers #2821 Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #4297
Answers rapidsai#2821 Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4297
Recent updates to FAISS now provide a means to plug in our own custom memory manager (RMM) so that we can control each allocation and deallocation.
This is needed on cuml, ideally before the approximate indices are included, since they require indexes with memory exclusively owned and managed by FAISS. This is particularly a concern when using the pool allocator, because a user could allocate most of their GPU's memory for RAPIDS RMM and be confused when they run KNN with approximate indices and receive out of memory errors.
The text was updated successfully, but these errors were encountered: