Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin dask & distributed in CI #4235

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Unpin dask & distributed in CI #4235

merged 2 commits into from
Oct 6, 2021

Conversation

galipremsagar
Copy link
Contributor

Changes to be in-line with: rapidsai/cudf#9307

@galipremsagar galipremsagar requested a review from a team as a code owner September 24, 2021 21:44
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Sep 24, 2021
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change conda conda issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function and removed gpuCI gpuCI issue conda conda issue labels Sep 24, 2021
@galipremsagar galipremsagar self-assigned this Sep 24, 2021
@cjnolet
Copy link
Member

cjnolet commented Sep 27, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Oct 6, 2021

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 6, 2021
@dantegd
Copy link
Member

dantegd commented Oct 6, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@8f75568). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4235   +/-   ##
===============================================
  Coverage                ?   86.06%           
===============================================
  Files                   ?      231           
  Lines                   ?    18691           
  Branches                ?        0           
===============================================
  Hits                    ?    16087           
  Misses                  ?     2604           
  Partials                ?        0
Flag Coverage Δ
dask 47.01% <0.00%> (?)
non-dask 78.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f75568...21847ff. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 119ac88 into rapidsai:branch-21.12 Oct 6, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@galipremsagar
Unpin dask & distributed in CI (rapidsai#4235)
f558ef3 
Changes to be in-line with: rapidsai/cudf#9307

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@dantegd dantegd dantegd approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge conda conda issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@galipremsagar @cjnolet @dantegd @codecov-commenter @ajschmidt8